Conversation
jsdw
added
R1-breaking_change
|
@bkchr Do you think we should update One constraint is that I'd like to get this merged before the release cutoff date on May 15th to get it into the next stable release, so my preference is to merge this first and update that later. |
Given the looser version requirements, no change to |
Makes sense! I guess it will eventually want to be updated for V16 metadata so that it can be used for decoding/checking v5 transactions (because V16 metadata contains the transaction extensions for each possible version the extrinsic might use)? |
jsdw
force-pushed
the
jsdw-stabilize-v16-metadata
branch
from
e7a4f98 to
af143e2
Compare
jsdw
force-pushed
the
jsdw-stabilize-v16-metadata
branch
from
af143e2 to
7659e90
Compare
|
I moved #8512 to this branch instead, as I was going down a rabbit hole in this branch thinking I needed to update subxt, and then the CI to support this (and the lockfile sortof as a result of Subxt update), and then things that started cropping up as a result of both of these. #8512 instead is trying to keep changes to a minimum and avoid this rabbit hole. The core changes are identical, with hopefully less fixing-CI fallout. |
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
This PR bumps frame-metadata 23.0.0, which stabilizes V16 metadata. This was previously available as the "unstable" metadata. The main additions provided by V16 metadata are: - Information about the Pallet View Functions exposed by pallets. - Information about the Config associated types used by each pallet. - Support for V5 transactions, including support for a chain providing multiple transaction extension versions and multiple supported transaciton versions. - Support for deprecation information, so that mostly anything defined in a runtime can be marked as deprecated in order for runtime/pallet authors to communicate to consumers about deprecated items. To sanity check this, I've built a polkadot node with this change and checked that using Subxt (this PR paritytech/subxt#1999), v16 metadata is indeed available, downloads and decodes correctly. <!-- ✄ ----------------------------------------------------------------------------- Thank you for your Pull Request! 🙏 Please make sure it follows the contribution guidelines outlined in [this document](https://github.com/paritytech/polkadot-sdk/blob/master/docs/contributor/CONTRIBUTING.md) and fill out the sections below. Once you're ready to submit your PR for review, please delete this section and leave only the text under the "Description" heading. # Description *A concise description of what your PR is doing, and what potential issue it is solving. Use [Github semantic linking](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword) to link the PR to an issue that must be closed once this is merged.* ## Integration *In depth notes about how this PR should be integrated by downstream projects. This part is mandatory, and should be reviewed by reviewers, if the PR does NOT have the `R0-Silent` label. In case of a `R0-Silent`, it can be ignored.* ## Review Notes *In depth notes about the **implementation** details of your PR. This should be the main guide for reviewers to understand your approach and effectively review it. If too long, use [`<details>`](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/details)*. *Imagine that someone who is depending on the old code wants to integrate your new code and the only information that they get is this section. It helps to include example usage and default value here, with a `diff` code-block to show possibly integration.* *Include your leftover TODOs, if any, here.* # Checklist * [ ] My PR includes a detailed description as outlined in the "Description" and its two subsections above. * [ ] My PR follows the [labeling requirements]( https://github.com/paritytech/polkadot-sdk/blob/master/docs/contributor/CONTRIBUTING.md#Process ) of this project (at minimum one label for `T` required) * External contributors: ask maintainers to put the right label on your PR. * [ ] I have made corresponding changes to the documentation (if applicable) * [ ] I have added tests that prove my fix is effective or that my feature works (if applicable) You can remove the "Checklist" section once all have been checked. Thank you for your contribution! ✄ ----------------------------------------------------------------------------- --. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Regenerate api-augment metadata and TypeScript type definitions from fresh stable2506 runtime binaries built via cargo build --release, crossbuild:mac, and docker:build. Reflects all runtime API and pallet changes from the polkadot-sdk stable2506 upgrade including V16 metadata stabilization (paritytech/polkadot-sdk#8443) and RuntimeEvent removal from pallet Config traits (paritytech/polkadot-sdk#7229). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-project-automation
bot
moved this from Todo
to Done
in [preview] release tracker
github-project-automation
bot
moved this from Todo
to Done
in [preview] release tracker
6 participants
This PR bumps frame-metadata 23.0.0, which stabilizes V16 metadata. This was previously available as the "unstable" metadata.
The main additions provided by V16 metadata are:
To sanity check this, I've built a polkadot node with this change and checked that using Subxt (this PR paritytech/subxt#1999), v16 metadata is indeed available, downloads and decodes correctly.