release/build-macos-binaries: add missing FEATURES argument #8816
Merged
iulianbarbu merged 2 commits intoparitytech:masterfrom Jun 11, 2025
Merged
Conversation
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
iulianbarbu
added
the
R0-no-crate-publish-required
alvicsam
approved these changes
Jun 10, 2025
lexnv
approved these changes
Jun 10, 2025
ggwpez
approved these changes
Jun 10, 2025
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
iulianbarbu
added
A4-backport-stable2412
A4-backport-stable2503
Merged
via the queue into
paritytech:master
with commit Jun 11, 2025
292368d
351 of 406 checks passed
paritytech-release-backport-bot bot
pushed a commit
that referenced
this pull request
Jun 11, 2025
# Description In #8755 we enabled release scripts to build binaries with certain features too, used especially for `polkadot-omni-node`. I missed to add the `FEATURES` argument to the build script used for macos: https://github.com/paritytech/polkadot-sdk/pull/8755/files#diff-f4ebb5b55e4d2f4ec7ab5674ac3376839b13358d78935f9c388d79e75beeceb8R224 ## Integration N/A ## Review Notes This must be merged to be able to build `polkadot-omni-node` binary with runtime-benchmarks feature on macos. Fixed also the macos build per: 05502a3. --------- Signed-off-by: Iulian Barbu <iulian.barbu@parity.io> (cherry picked from commit 292368d)
|
Successfully created backport PR for |
paritytech-release-backport-bot bot
pushed a commit
that referenced
this pull request
Jun 11, 2025
# Description In #8755 we enabled release scripts to build binaries with certain features too, used especially for `polkadot-omni-node`. I missed to add the `FEATURES` argument to the build script used for macos: https://github.com/paritytech/polkadot-sdk/pull/8755/files#diff-f4ebb5b55e4d2f4ec7ab5674ac3376839b13358d78935f9c388d79e75beeceb8R224 ## Integration N/A ## Review Notes This must be merged to be able to build `polkadot-omni-node` binary with runtime-benchmarks feature on macos. Fixed also the macos build per: 05502a3. --------- Signed-off-by: Iulian Barbu <iulian.barbu@parity.io> (cherry picked from commit 292368d)
|
Successfully created backport PR for |
paritytech-release-backport-bot bot
pushed a commit
that referenced
this pull request
Jun 11, 2025
# Description In #8755 we enabled release scripts to build binaries with certain features too, used especially for `polkadot-omni-node`. I missed to add the `FEATURES` argument to the build script used for macos: https://github.com/paritytech/polkadot-sdk/pull/8755/files#diff-f4ebb5b55e4d2f4ec7ab5674ac3376839b13358d78935f9c388d79e75beeceb8R224 ## Integration N/A ## Review Notes This must be merged to be able to build `polkadot-omni-node` binary with runtime-benchmarks feature on macos. Fixed also the macos build per: 05502a3. --------- Signed-off-by: Iulian Barbu <iulian.barbu@parity.io> (cherry picked from commit 292368d)
|
Successfully created backport PR for |
ordian
added a commit
that referenced
this pull request
Jun 12, 2025
* master: (62 commits) release/build-macos-binaries: add missing FEATURES argument (#8816) Add XCM Precompile to `pallet-xcm` (#8693) [Release|CI/CD] Exclude test runtimes from the runtimes build (#8820) Add freebsd sysinfo for telemetry (#7985) release-reusable-rc-build: add optional `features` input that can be considered for nodes building (#8755) [Staking] Cleanups and some improvements (#8701) Fix typos in 3 files in Implementers Guide (#8799) Update `RemoteExporter` docs to reflect removal of `forward_id_for` (#8795) Snowbridge: enforce fee when registering Polkadot native asset (#8725) Bump the ci_dependencies group across 1 directory with 7 updates (#8788) Docker hub 'master' image short sha (#8790) [Release|CI/CD] Combine branch-off and RC automation flows (#8754) Move Transaction depth limit checks (#8750) Add genesis presets for remaining runtimes in polkadot-parachain-bin (#8426) Do not make pallet-identity benchmarks signature-dependent (#8179) Introduction of Approval Slashes [Disabling Strategy Stage 4] (#6827) [AHM] Prepare For Westend Cleanup (#8715) Actually use RP offset in YAP parachain (#8745) [AHM] Relax the requirement for RC-Client to receive +1 session reports (#8702) Don't read storage items in logging (#8749) ...
EgorPopelyaev
added a commit
that referenced
this pull request
Jun 13, 2025
Backport #8816 into `stable2412` from iulianbarbu. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Signed-off-by: Iulian Barbu <iulian.barbu@parity.io> Co-authored-by: Iulian Barbu <14218860+iulianbarbu@users.noreply.github.com> Co-authored-by: EgorPopelyaev <egor@parity.io>
EgorPopelyaev
pushed a commit
that referenced
this pull request
Jun 13, 2025
Backport #8816 into `stable2503` from iulianbarbu. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Signed-off-by: Iulian Barbu <iulian.barbu@parity.io> Co-authored-by: Iulian Barbu <14218860+iulianbarbu@users.noreply.github.com>
EgorPopelyaev
pushed a commit
that referenced
this pull request
Jun 23, 2025
Backport #8816 into `stable2506` from iulianbarbu. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Signed-off-by: Iulian Barbu <iulian.barbu@parity.io> Co-authored-by: Iulian Barbu <14218860+iulianbarbu@users.noreply.github.com>
alvicsam
pushed a commit
that referenced
this pull request
Oct 17, 2025
# Description In #8755 we enabled release scripts to build binaries with certain features too, used especially for `polkadot-omni-node`. I missed to add the `FEATURES` argument to the build script used for macos: https://github.com/paritytech/polkadot-sdk/pull/8755/files#diff-f4ebb5b55e4d2f4ec7ab5674ac3376839b13358d78935f9c388d79e75beeceb8R224 ## Integration N/A ## Review Notes This must be merged to be able to build `polkadot-omni-node` binary with runtime-benchmarks feature on macos. Fixed also the macos build per: 05502a3. --------- Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In #8755 we enabled release scripts to build binaries with certain features too, used especially for
polkadot-omni-node. I missed to add theFEATURESargument to the build script used for macos:https://github.com/paritytech/polkadot-sdk/pull/8755/files#diff-f4ebb5b55e4d2f4ec7ab5674ac3376839b13358d78935f9c388d79e75beeceb8R224
Integration
N/A
Review Notes
This must be merged to be able to build
polkadot-omni-nodebinary with runtime-benchmarks feature on macos.Fixed also the macos build per: 05502a3.