[stable2412] Backport #8816#8824
Merged
EgorPopelyaev merged 2 commits intostable2412from Jun 13, 2025
Merged
Conversation
# Description In #8755 we enabled release scripts to build binaries with certain features too, used especially for `polkadot-omni-node`. I missed to add the `FEATURES` argument to the build script used for macos: https://github.com/paritytech/polkadot-sdk/pull/8755/files#diff-f4ebb5b55e4d2f4ec7ab5674ac3376839b13358d78935f9c388d79e75beeceb8R224 ## Integration N/A ## Review Notes This must be merged to be able to build `polkadot-omni-node` binary with runtime-benchmarks feature on macos. Fixed also the macos build per: 05502a3. --------- Signed-off-by: Iulian Barbu <iulian.barbu@parity.io> (cherry picked from commit 292368d)
Contributor
|
This pull request is amending an existing release. Please proceed with extreme caution,
Emergency Bypass
If you really need to bypass this check: add |
iulianbarbu
approved these changes
Jun 12, 2025
EgorPopelyaev
approved these changes
Jun 13, 2025
… into backport-8816-to-stable2412
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #8816 into
stable2412from iulianbarbu.See the documentation on how to use this bot.