Skip to content

[stable2412] Backport #8816#8824

Merged
EgorPopelyaev merged 2 commits intostable2412from
backport-8816-to-stable2412
Jun 13, 2025
Merged

[stable2412] Backport #8816#8824
EgorPopelyaev merged 2 commits intostable2412from
backport-8816-to-stable2412

Conversation

@paritytech-release-backport-bot
Copy link
Copy Markdown

Backport #8816 into stable2412 from iulianbarbu.

See the documentation on how to use this bot.

# Description

In #8755 we enabled release scripts to build binaries with certain
features too, used especially for `polkadot-omni-node`. I missed to add
the `FEATURES` argument to the build script used for macos:

https://github.com/paritytech/polkadot-sdk/pull/8755/files#diff-f4ebb5b55e4d2f4ec7ab5674ac3376839b13358d78935f9c388d79e75beeceb8R224

## Integration

N/A

## Review Notes

This must be merged to be able to build `polkadot-omni-node` binary with
runtime-benchmarks feature on macos.
Fixed also the macos build per:
05502a3.

---------

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
(cherry picked from commit 292368d)
@github-actions
Copy link
Copy Markdown
Contributor

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@EgorPopelyaev EgorPopelyaev merged commit 4a37997 into stable2412 Jun 13, 2025
43 of 45 checks passed
@EgorPopelyaev EgorPopelyaev deleted the backport-8816-to-stable2412 branch June 13, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A3-backport Pull request is already reviewed well in another branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants