Snowbridge: enforce fee when registering Polkadot native asset by yrong · Pull Request #8725 · paritytech/polkadot-sdk

yrong · 2025-06-03T05:53:03Z

Resolves: https://linear.app/snowfork/issue/SNO-1497

yrong · 2025-06-03T06:10:11Z

@claravanstaden Please check this commit, looks like we missed applying the burn fee when adding a tip?

claravanstaden · 2025-06-03T06:34:56Z

@yrong good catch, I definitely missed that. 🫤

claravanstaden

Nice!

bridges/snowbridge/pallets/system-frontend/src/lib.rs

…adot-sdk into register-pna-with-fee

bridges/snowbridge/pallets/system-frontend/src/benchmarking.rs

bridges/snowbridge/pallets/system-frontend/src/tests.rs

cumulus/parachains/runtimes/assets/asset-hub-westend/src/xcm_config.rs

bridges/snowbridge/pallets/system-frontend/src/lib.rs

cumulus/parachains/runtimes/assets/asset-hub-westend/src/xcm_config.rs

…adot-sdk into register-pna-with-fee

bridges/snowbridge/pallets/system-frontend/src/lib.rs

acatangiu · 2025-06-04T16:24:49Z

bridges/snowbridge/pallets/system-frontend/src/lib.rs

-			let remote_xcm = Self::build_remote_xcm(&call);
-			let message_id = Self::send_xcm(origin_location, dest.clone(), remote_xcm.clone())
-				.map_err(|error| Error::<T>::from(error))?;
+			let ether_gained = Self::swap_fee_asset_and_burn(origin_location.clone(), fee_asset)?;


This will fail for Root origin when fee_asset is non-zero.

Suggested change

let ether_gained = Self::swap_fee_asset_and_burn(origin_location.clone(), fee_asset)?;

let ether_gained = if origin_location.is_here() {

// Root origin/location does not pay any fees/tip.

0

} else {

Self::swap_fee_asset_and_burn(origin_location.clone(), fee_asset)?

};

Nice catch!
5df1115

I would still prefer not to call this function at all for Root, but not going to block on it.

…adot-sdk into register-pna-with-fee

claravanstaden

Looks like you need to fix the PR doc versions, otherwise looks good!

yrong · 2025-06-05T15:50:16Z

Looks like you need to fix the PR doc versions, otherwise looks good!

I've added validate: false to supress the semver check but it does not seem to work — not sure if I did it correctly.

I remember Adrian mentioned that since we're the only end user of these packages, the semver check does't really matter.

x3c41a · 2025-06-09T10:54:12Z

bridges/snowbridge/pallets/system-frontend/src/benchmarking.rs

 			decimals: 12,
 		};

+		let fee_asset = Asset::from((Location::parent(), 1_000_000u128));


nit: maybe 1_000_000u128 should be a const with some descriptive name?

paritytech-release-backport-bot · 2025-06-09T11:51:48Z

Created backport PR for stable2503:

[stable2503] Backport #8725 #8797 with remaining conflicts!

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-8725-to-stable2503
git worktree add --checkout .worktree/backport-8725-to-stable2503 backport-8725-to-stable2503
cd .worktree/backport-8725-to-stable2503
git reset --hard HEAD^
git cherry-pick -x 36c3039007866480be258d9645626c56ab168d69
git push --force-with-lease

paritytech-release-backport-bot · 2025-06-09T11:51:49Z

Backport failed for stable2506: couldn't find remote ref stable2506.
Please ensure that this Github repo has a branch named stable2506.

Resolves: https://linear.app/snowfork/issue/SNO-1497

Backport #8725 into `stable2503` from yrong. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot.  --------- Co-authored-by: Ron <yrong1997@gmail.com> Co-authored-by: Adrian Catangiu <adrian@parity.io> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* master: (62 commits) release/build-macos-binaries: add missing FEATURES argument (#8816) Add XCM Precompile to `pallet-xcm` (#8693) [Release|CI/CD] Exclude test runtimes from the runtimes build (#8820) Add freebsd sysinfo for telemetry (#7985) release-reusable-rc-build: add optional `features` input that can be considered for nodes building (#8755) [Staking] Cleanups and some improvements (#8701) Fix typos in 3 files in Implementers Guide (#8799) Update `RemoteExporter` docs to reflect removal of `forward_id_for` (#8795) Snowbridge: enforce fee when registering Polkadot native asset (#8725) Bump the ci_dependencies group across 1 directory with 7 updates (#8788) Docker hub 'master' image short sha (#8790) [Release|CI/CD] Combine branch-off and RC automation flows (#8754) Move Transaction depth limit checks (#8750) Add genesis presets for remaining runtimes in polkadot-parachain-bin (#8426) Do not make pallet-identity benchmarks signature-dependent (#8179) Introduction of Approval Slashes [Disabling Strategy Stage 4] (#6827) [AHM] Prepare For Westend Cleanup (#8715) Actually use RP offset in YAP parachain (#8745) [AHM] Relax the requirement for RC-Client to receive +1 session reports (#8702) Don't read storage items in logging (#8749) ...

Backport paritytech#8725 into `stable2503` from yrong. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot.  --------- Co-authored-by: Ron <yrong1997@gmail.com> Co-authored-by: Adrian Catangiu <adrian@parity.io> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Resolves: https://linear.app/snowfork/issue/SNO-1497

yrong added 2 commits June 3, 2025 13:48

Register PNA with fee

0b35bc6

Burn fee for adding a tip

f719fbe

Fix runtime

09e61be

claravanstaden reviewed Jun 3, 2025

View reviewed changes

bridges/snowbridge/pallets/system-frontend/src/lib.rs Show resolved Hide resolved

bridges/snowbridge/pallets/system-frontend/src/lib.rs Outdated Show resolved Hide resolved

yrong added 5 commits June 3, 2025 18:30

Refactor function swap_fee_asset_and_burn

d2f43b9

Refactor a common function send_transact_call

8c85471

Fix the breaking tests

b759f57

Add prdoc

5d433e9

Merge branch 'master' into register-pna-with-fee

d82423d

yrong marked this pull request as ready for review June 3, 2025 15:25

paritytech-review-bot bot requested a review from a team June 3, 2025 15:26

yrong changed the title ~~Snowbridge: register polkadot native asset with fee~~ Snowbridge: enforce fee when registering Polkadot native asset Jun 3, 2025

yrong added 3 commits June 4, 2025 09:31

Fix benchmark

d87e93e

Merge branch 'register-pna-with-fee' of https://github.com/yrong/polk…

38ed577

…adot-sdk into register-pna-with-fee

Fix semver

629386f

claravanstaden reviewed Jun 4, 2025

View reviewed changes

bridges/snowbridge/pallets/system-frontend/src/benchmarking.rs Outdated Show resolved Hide resolved

bridges/snowbridge/pallets/system-frontend/src/tests.rs Show resolved Hide resolved

acatangiu reviewed Jun 4, 2025

View reviewed changes

cumulus/parachains/runtimes/assets/asset-hub-westend/src/xcm_config.rs Outdated Show resolved Hide resolved

acatangiu requested changes Jun 4, 2025

View reviewed changes

bridges/snowbridge/pallets/system-frontend/src/lib.rs Outdated Show resolved Hide resolved

cumulus/parachains/runtimes/assets/asset-hub-westend/src/xcm_config.rs Outdated Show resolved Hide resolved

Use Location as parameter

8f55705

paritytech-review-bot bot requested a review from a team June 4, 2025 13:29

yrong added 6 commits June 4, 2025 21:48

Allow zero fee

029da09

Merge branch 'master' into register-pna-with-fee

bf2fabe

Remove the DescribeTerminus converter

27063ec

Merge branch 'master' into register-pna-with-fee

ac05cc3

Benchmark with swapped Ether

7f764c6

Merge branch 'register-pna-with-fee' of https://github.com/yrong/polk…

e56fe4c

…adot-sdk into register-pna-with-fee

acatangiu reviewed Jun 4, 2025

View reviewed changes

More tests

569c342

acatangiu moved this to To be released (SDK) in fellowship/runtimes integrations queue Jun 5, 2025

yrong added 3 commits June 5, 2025 18:28

Check root origin first

5a3e966

Merge branch 'register-pna-with-fee' of https://github.com/yrong/polk…

c63ab8b

…adot-sdk into register-pna-with-fee

Merge branch 'master' into register-pna-with-fee

55c4f61

yrong requested a review from claravanstaden June 5, 2025 14:10

claravanstaden approved these changes Jun 5, 2025

View reviewed changes

Merge branch 'master' into register-pna-with-fee

946f280

acatangiu added the A4-backport-stable2503 Pull request must be backported to the stable2503 release branch label Jun 9, 2025

x3c41a reviewed Jun 9, 2025

View reviewed changes

x3c41a approved these changes Jun 9, 2025

View reviewed changes

acatangiu added the A4-backport-stable2506 Pull request must be backported to the stable2506 release branch label Jun 9, 2025

acatangiu added this pull request to the merge queue Jun 9, 2025

Merged via the queue into paritytech:master with commit 36c3039 Jun 9, 2025
395 of 398 checks passed

paritytech-release-backport-bot bot mentioned this pull request Jun 9, 2025

[stable2503] Backport #8725 #8797

Merged

acatangiu removed the A4-backport-stable2506 Pull request must be backported to the stable2506 release branch label Jun 10, 2025

pgherveou pushed a commit that referenced this pull request Jun 11, 2025

Snowbridge: enforce fee when registering Polkadot native asset (#8725)

0581a29

Resolves: https://linear.app/snowfork/issue/SNO-1497

alvicsam pushed a commit that referenced this pull request Oct 17, 2025

Snowbridge: enforce fee when registering Polkadot native asset (#8725)

a431c00

Resolves: https://linear.app/snowfork/issue/SNO-1497

github-actions bot mentioned this pull request Oct 24, 2025

Update polkadot-sdk from stable2503 to stable2506 moondance-labs/tanssi#1340

Closed

pgherveou added this to [preview] release tracker Mar 20, 2026

github-project-automation bot moved this to Done in [preview] release tracker Mar 20, 2026

pgherveou removed this from [preview] release tracker Mar 20, 2026

pgherveou added this to [preview] release tracker Mar 23, 2026

github-project-automation bot moved this to Done in [preview] release tracker Mar 23, 2026

-			let ether_gained = Self::swap_fee_asset_and_burn(origin_location.clone(), fee_asset)?;
+			let ether_gained = if origin_location.is_here() {
+				// Root origin/location does not pay any fees/tip.
+			} else {
+				Self::swap_fee_asset_and_burn(origin_location.clone(), fee_asset)?
+			};

Conversation

yrong commented Jun 3, 2025

Uh oh!

yrong commented Jun 3, 2025

Uh oh!

claravanstaden commented Jun 3, 2025

Uh oh!

claravanstaden left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

acatangiu Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

yrong Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

acatangiu Jun 5, 2025

Choose a reason for hiding this comment

Uh oh!

yrong Jun 5, 2025

Choose a reason for hiding this comment

Uh oh!

claravanstaden left a comment

Choose a reason for hiding this comment

Uh oh!

yrong commented Jun 5, 2025

Uh oh!

x3c41a Jun 9, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

paritytech-release-backport-bot bot commented Jun 9, 2025

Uh oh!

paritytech-release-backport-bot bot commented Jun 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants