Don't read storage items in logging#8749
Merged
kianenigma merged 7 commits intomasterfrom Jun 4, 2025
Merged
Conversation
Contributor
kianenigma
commented
Jun 4, 2025
kianenigma
commented
- Should fix 📣 Westend Asset Hub Stalling Issue #8735
- Adds some reference document about this behavior
kianenigma
added
the
R0-no-crate-publish-required
bkchr
reviewed
Jun 4, 2025
athei
approved these changes
Jun 4, 2025
bkontur
approved these changes
Jun 4, 2025
sigurpol
approved these changes
Jun 4, 2025
Co-authored-by: Bastian Köcher <git@kchr.de>
sigurpol
reviewed
Jun 4, 2025
| //! chain and the parachain, when execution the Parachain Validation Function (PVF) on the relay | ||
| //! chain. | ||
| //! | ||
| //! **In summary, you should only used storage values in logging (especially for levels lower than |
Contributor
There was a problem hiding this comment.
Suggested change
| //! **In summary, you should only used storage values in logging (especially for levels lower than | |
| //! **In summary, you should only use storage values in logging (especially for levels lower than |
Contributor
There was a problem hiding this comment.
To be on the safe side, I would remove the section regarding levels lower than info.
sigurpol
approved these changes
Jun 4, 2025
pgherveou
pushed a commit
that referenced
this pull request
Jun 11, 2025
- [x] Should fix #8735 - [x] Adds some reference document about this behavior --------- Co-authored-by: Bastian Köcher <git@kchr.de>
ordian
added a commit
that referenced
this pull request
Jun 12, 2025
* master: (62 commits) release/build-macos-binaries: add missing FEATURES argument (#8816) Add XCM Precompile to `pallet-xcm` (#8693) [Release|CI/CD] Exclude test runtimes from the runtimes build (#8820) Add freebsd sysinfo for telemetry (#7985) release-reusable-rc-build: add optional `features` input that can be considered for nodes building (#8755) [Staking] Cleanups and some improvements (#8701) Fix typos in 3 files in Implementers Guide (#8799) Update `RemoteExporter` docs to reflect removal of `forward_id_for` (#8795) Snowbridge: enforce fee when registering Polkadot native asset (#8725) Bump the ci_dependencies group across 1 directory with 7 updates (#8788) Docker hub 'master' image short sha (#8790) [Release|CI/CD] Combine branch-off and RC automation flows (#8754) Move Transaction depth limit checks (#8750) Add genesis presets for remaining runtimes in polkadot-parachain-bin (#8426) Do not make pallet-identity benchmarks signature-dependent (#8179) Introduction of Approval Slashes [Disabling Strategy Stage 4] (#6827) [AHM] Prepare For Westend Cleanup (#8715) Actually use RP offset in YAP parachain (#8745) [AHM] Relax the requirement for RC-Client to receive +1 session reports (#8702) Don't read storage items in logging (#8749) ...
alvicsam
pushed a commit
that referenced
this pull request
Oct 17, 2025
- [x] Should fix #8735 - [x] Adds some reference document about this behavior --------- Co-authored-by: Bastian Köcher <git@kchr.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.