Skip to content

[pallet-revive] contract's nonce starts at 1#8734

Merged
pgherveou merged 3 commits intomasterfrom
pg/contracts-nonce
Jun 4, 2025
Merged

[pallet-revive] contract's nonce starts at 1#8734
pgherveou merged 3 commits intomasterfrom
pg/contracts-nonce

Conversation

@pgherveou
Copy link
Copy Markdown
Contributor

@pgherveou pgherveou commented Jun 3, 2025

@pgherveou
Copy link
Copy Markdown
Contributor Author

/cmd prdoc --audience runtime_dev --bump patch

@pgherveou pgherveou added the T7-smart_contracts This PR/Issue is related to smart contracts. label Jun 3, 2025
@pgherveou
Copy link
Copy Markdown
Contributor Author

/cmd prdoc --audience runtime_dev --bump minor --force

@pgherveou pgherveou requested review from athei and xermicus and removed request for xermicus June 3, 2025 15:03
@pgherveou
Copy link
Copy Markdown
Contributor Author

pgherveou commented Jun 3, 2025

ideally all account starts with nonce = 1 by default
and implement in substrate/frame/system/src/lib.rs, but this will probably break a lot of tests

impl<Nonce: Default + From<u32>, AccountData: Default> Default for AccountInfo<Nonce, AccountData> {
	fn default() -> Self {
		Self {
			nonce: 1u32.into(),
			consumers: Default::default(),
			providers: Default::default(),
			sufficients: Default::default(),
			data: Default::default(),
		}
	}
}

Copy link
Copy Markdown
Member

@xermicus xermicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@pgherveou pgherveou added this pull request to the merge queue Jun 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 4, 2025
@pgherveou pgherveou added this pull request to the merge queue Jun 4, 2025
Merged via the queue into master with commit b24707c Jun 4, 2025
250 checks passed
@pgherveou pgherveou deleted the pg/contracts-nonce branch June 4, 2025 13:19
ordian added a commit that referenced this pull request Jun 4, 2025
* master:
  omni-node: fix `benchmark pallet` to work with `--runtime` (#8594)
  Handle and suppress "New unknown `FromSwarm` libp2p event" warning (#8731)
  Implement detailed logging for XCM failures (#8724)
  [pallet-revive] contract's nonce starts at 1 (#8734)
  sync/fix: Clear gap sync on known imported blocks (#8445)
  [PoP] Add personhood tracking pallets (#8164)
  client/net: Use litep2p as the default network backend (#8461)
  Unflake `returns_status_for_pruned_blocks` (#8709)
  [AHM] Report the weights of epmb pallet to expose kusama and polkadot weights (#8704)
  Remove all XCM dependencies from `pallet-revive` (#8584)
  Docker master image tag fix (#8711)
  Record ed as part of the storage deposit (#8718)
  [pallet-revive] update dry-run logic (#8662)
  feat: add collator peer ID to ParachainInherentData (#8708)
  Nest errors in pallet-xcm (#7730)
  pallet-assets ERC20 precompile (#8554)
  Broker: Introduce min price + adjust renewals to lower market. (#8630)
  [AHM] Staking async fixes for XCM and election planning (#8422)
  Staking (EPMB): Add defensive error handling to voter snapshot creation and solution verification (#8687)
pgherveou added a commit that referenced this pull request Jun 11, 2025
nonce starting value should be 1 see
https://github.com/ethereum/EIPs/blob/master/EIPS/eip-161.md

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
alvicsam pushed a commit that referenced this pull request Oct 17, 2025
nonce starting value should be 1 see
https://github.com/ethereum/EIPs/blob/master/EIPS/eip-161.md

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T7-smart_contracts This PR/Issue is related to smart contracts.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants