omni-node: fix `benchmark pallet` to work with `--runtime` by iulianbarbu · Pull Request #8594 · paritytech/polkadot-sdk

iulianbarbu · 2025-05-21T11:49:48Z

Description

The PR fixes the logic so that polkadot-omni-node benchmark pallet subcommand pulls in the appropriate arguments, while not needing to instatiate the full node configuration, which requires always passing --chain flag.

Integration

Developers will be able to use polkadot-omni-node benchmark pallet with --runtime flag, same as frame-omni-bencher.

Review Notes

Did a few things in this PR:

made polkadot-omni-node benchmark pallet not require always the --chain flag
removed the deprecated run method for benchmark pallet from benchmarking-cli.
removed the check that disallows the chain flag from frame-omni-bencher since it is allowed and usable

TODO:

a few more testing of the commands with both --runtime and --chain.
remove runtime-benchmarks feature guard for benchmark cmds

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

iulianbarbu · 2025-05-21T11:50:32Z

/cmd prdoc

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

cumulus/polkadot-omni-node/lib/src/command.rs

substrate/utils/frame/omni-bencher/src/command.rs

bkontur · 2025-05-21T12:31:04Z

Developers will be able to use polkadot-omni-node benchmark pallet with --runtime flag, same as frame-omni-bencher.

@iulianbarbu Does this apply also to polkadot-parachain-bin?

@franciscoaguirre This is something you asked me about in the morning. Looks like Iulian "heard" our element conversation :D

iulianbarbu · 2025-05-21T12:32:06Z

Does this apply also to polkadot-parachain-bin?

Yes it does.

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

cumulus/polkadot-omni-node/lib/src/command.rs

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

cumulus/polkadot-omni-node/lib/src/command.rs

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

cumulus/polkadot-omni-node/lib/Cargo.toml

This reverts commit 4a3f245.

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

* master: omni-node: fix `benchmark pallet` to work with `--runtime` (#8594) Handle and suppress "New unknown `FromSwarm` libp2p event" warning (#8731) Implement detailed logging for XCM failures (#8724) [pallet-revive] contract's nonce starts at 1 (#8734) sync/fix: Clear gap sync on known imported blocks (#8445) [PoP] Add personhood tracking pallets (#8164) client/net: Use litep2p as the default network backend (#8461) Unflake `returns_status_for_pruned_blocks` (#8709) [AHM] Report the weights of epmb pallet to expose kusama and polkadot weights (#8704) Remove all XCM dependencies from `pallet-revive` (#8584) Docker master image tag fix (#8711) Record ed as part of the storage deposit (#8718) [pallet-revive] update dry-run logic (#8662) feat: add collator peer ID to ParachainInherentData (#8708) Nest errors in pallet-xcm (#7730) pallet-assets ERC20 precompile (#8554) Broker: Introduce min price + adjust renewals to lower market. (#8630) [AHM] Staking async fixes for XCM and election planning (#8422) Staking (EPMB): Add defensive error handling to voter snapshot creation and solution verification (#8687)

# Description The PR fixes the logic so that `polkadot-omni-node benchmark pallet` subcommand pulls in the appropriate arguments, while not needing to instatiate the full node configuration, which requires always passing `--chain` flag. ## Integration Developers will be able to use `polkadot-omni-node benchmark pallet` with `--runtime` flag, same as `frame-omni-bencher`. ## Review Notes Did a few things in this PR: - made `polkadot-omni-node benchmark pallet` not require always the `--chain` flag - removed the deprecated `run` method for `benchmark pallet` from `benchmarking-cli`. - removed the check that disallows the chain flag from `frame-omni-bencher` since it is allowed and usable TODO: - [x] a few more testing of the commands with both `--runtime` and `--chain`. - [x] remove `runtime-benchmarks` feature guard for benchmark cmds --------- Signed-off-by: Iulian Barbu <iulian.barbu@parity.io> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>

iulianbarbu added 2 commits May 21, 2025 08:09

omni-node: chain is optional for benchmark pallet

83301f8

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

benchmark-cli/omni-bencher cleanup

0f72176

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

iulianbarbu self-assigned this May 21, 2025

Merge branch 'master' into ib-benchmark-parity

d8b6ce1

iulianbarbu requested a review from serban300 May 21, 2025 11:50

iulianbarbu changed the title ~~omni-node: fix benchmark pallet to work just with --runtime too~~ omni-node: fix benchmark pallet to work with --runtime May 21, 2025

github-actions bot and others added 2 commits May 21, 2025 11:55

Update from github-actions[bot] running command 'prdoc'

8d29613

make it more explicit

45ff224

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

iulianbarbu mentioned this pull request May 21, 2025

polkadot-omni-node: Merge (back) bencher, chain-spec (and even try-runtime) #5567

Closed

iulianbarbu added the I2-bug The node fails to follow expected behavior. label May 21, 2025

update prdoc

bb1a4ff

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

iulianbarbu requested review from ggwpez and skunert May 21, 2025 12:10

iulianbarbu commented May 21, 2025

View reviewed changes

cumulus/polkadot-omni-node/lib/src/command.rs Outdated Show resolved Hide resolved

Update cumulus/polkadot-omni-node/lib/src/command.rs

4cd9ef5

bkontur reviewed May 21, 2025

View reviewed changes

substrate/utils/frame/omni-bencher/src/command.rs Show resolved Hide resolved

iulianbarbu and others added 2 commits May 21, 2025 15:17

fix chain flag origin

fc23601

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

Merge branch 'master' into ib-benchmark-parity

ac65b8c

bkchr reviewed May 21, 2025

View reviewed changes

cumulus/polkadot-omni-node/lib/src/command.rs Outdated Show resolved Hide resolved

iulianbarbu enabled auto-merge May 22, 2025 05:37

iulianbarbu disabled auto-merge May 22, 2025 05:37

iulianbarbu and others added 4 commits May 22, 2025 10:04

return load spec error instead of run_with_spec's

99ed13e

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

revert unneeded change

e9525f9

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

Merge branch 'master' into ib-benchmark-parity

566edb1

Merge branch 'master' into ib-benchmark-parity

8fe8204

bkchr approved these changes May 26, 2025

View reviewed changes

cumulus/polkadot-omni-node/lib/src/command.rs Show resolved Hide resolved

Merge branch 'master' into ib-benchmark-parity

03e1ba0

iulianbarbu and others added 6 commits June 2, 2025 17:37

no need to feature guard benchmark subcommands

101ba27

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

Merge branch 'master' into ib-benchmark-parity

35e23c6

revert unwanted change

a4e33b6

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

this shouldn't miss

a7d5c52

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

Merge branch 'master' into ib-benchmark-parity

bc1c323

reverted the runtime-benchmarks feature guarding

1e9a691

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

serban300 approved these changes Jun 3, 2025

View reviewed changes

iulianbarbu and others added 5 commits June 3, 2025 14:02

build polkadot-omni-node-lib and nodes with runtime-benchmarks

4a3f245

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

Merge branch 'master' into ib-benchmark-parity

689ce7e

fix umbrella

c991d84

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

fixed toml

8dfae33

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

some more fixes

763329a

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

ggwpez reviewed Jun 3, 2025

View reviewed changes

cumulus/polkadot-omni-node/lib/Cargo.toml Outdated Show resolved Hide resolved

bkontur mentioned this pull request Jun 4, 2025

polkadot-omni-node: clarify if we need to enable ignored tests #8736

Open

iulianbarbu added 2 commits June 4, 2025 10:23

Revert "build polkadot-omni-node-lib and nodes with runtime-benchmarks"

820539c

This reverts commit 4a3f245.

remove leftovers

5afb0cd

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

skunert approved these changes Jun 4, 2025

View reviewed changes

iulianbarbu added this pull request to the merge queue Jun 4, 2025

Merged via the queue into paritytech:master with commit d9e16fd Jun 4, 2025
246 checks passed

iulianbarbu deleted the ib-benchmark-parity branch June 4, 2025 16:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

omni-node: fix `benchmark pallet` to work with `--runtime`#8594

omni-node: fix `benchmark pallet` to work with `--runtime`#8594
iulianbarbu merged 27 commits intoparitytech:masterfrom
iulianbarbu:ib-benchmark-parity

iulianbarbu commented May 21, 2025 •

edited

Loading

Uh oh!

iulianbarbu commented May 21, 2025

Uh oh!

Uh oh!

Uh oh!

bkontur commented May 21, 2025

Uh oh!

iulianbarbu commented May 21, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

iulianbarbu commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Integration

Review Notes

Uh oh!

iulianbarbu commented May 21, 2025

Uh oh!

Uh oh!

Uh oh!

bkontur commented May 21, 2025

Uh oh!

iulianbarbu commented May 21, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

iulianbarbu commented May 21, 2025 •

edited

Loading