Skip to content

Handle and suppress "New unknown FromSwarm libp2p event" warning#8731

Merged
dmitry-markin merged 1 commit intomasterfrom
dm-suppress-new-addr-of-peer
Jun 4, 2025
Merged

Handle and suppress "New unknown FromSwarm libp2p event" warning#8731
dmitry-markin merged 1 commit intomasterfrom
dm-suppress-new-addr-of-peer

Conversation

@dmitry-markin
Copy link
Copy Markdown
Contributor

@dmitry-markin dmitry-markin commented Jun 3, 2025

Suppress annoying warning New unknown FromSwarm libp2p event: NewExternalAddrOfPeer(NewExternalAddrOfPeer { peer_id: PeerId("..."), addr: "..." }).

In Notifications behavior, where this warning is generated, the event does not provide useful information and can be safely ignored. In other behaviors it is passed through for possible future internal use by libp2p.

Close #7264.

@dmitry-markin dmitry-markin requested a review from lexnv June 3, 2025 12:21
@dmitry-markin dmitry-markin added R0-no-crate-publish-required The change does not require any crates to be re-published. T0-node This PR/Issue is related to the topic “node”. labels Jun 3, 2025
@lexnv
Copy link
Copy Markdown
Contributor

lexnv commented Jun 3, 2025

Nice one! Thanks for handling this 🙏

@dmitry-markin dmitry-markin added this pull request to the merge queue Jun 4, 2025
Merged via the queue into master with commit f9347a2 Jun 4, 2025
266 of 321 checks passed
@dmitry-markin dmitry-markin deleted the dm-suppress-new-addr-of-peer branch June 4, 2025 16:03
@github-project-automation github-project-automation bot moved this to Blocked ⛔️ in Networking Jun 4, 2025
ordian added a commit that referenced this pull request Jun 4, 2025
* master:
  omni-node: fix `benchmark pallet` to work with `--runtime` (#8594)
  Handle and suppress "New unknown `FromSwarm` libp2p event" warning (#8731)
  Implement detailed logging for XCM failures (#8724)
  [pallet-revive] contract's nonce starts at 1 (#8734)
  sync/fix: Clear gap sync on known imported blocks (#8445)
  [PoP] Add personhood tracking pallets (#8164)
  client/net: Use litep2p as the default network backend (#8461)
  Unflake `returns_status_for_pruned_blocks` (#8709)
  [AHM] Report the weights of epmb pallet to expose kusama and polkadot weights (#8704)
  Remove all XCM dependencies from `pallet-revive` (#8584)
  Docker master image tag fix (#8711)
  Record ed as part of the storage deposit (#8718)
  [pallet-revive] update dry-run logic (#8662)
  feat: add collator peer ID to ParachainInherentData (#8708)
  Nest errors in pallet-xcm (#7730)
  pallet-assets ERC20 precompile (#8554)
  Broker: Introduce min price + adjust renewals to lower market. (#8630)
  [AHM] Staking async fixes for XCM and election planning (#8422)
  Staking (EPMB): Add defensive error handling to voter snapshot creation and solution verification (#8687)
pgherveou pushed a commit that referenced this pull request Jun 11, 2025
…8731)

Suppress annoying warning `New unknown FromSwarm libp2p event:
NewExternalAddrOfPeer(NewExternalAddrOfPeer { peer_id: PeerId("..."),
addr: "..." })`.

In `Notifications` behavior, where this warning is generated, the event
does not provide useful information and can be safely ignored. In other
behaviors it is passed through for possible future internal use by
`libp2p`.

Close #7264.
alvicsam pushed a commit that referenced this pull request Oct 17, 2025
…8731)

Suppress annoying warning `New unknown FromSwarm libp2p event:
NewExternalAddrOfPeer(NewExternalAddrOfPeer { peer_id: PeerId("..."),
addr: "..." })`.

In `Notifications` behavior, where this warning is generated, the event
does not provide useful information and can be safely ignored. In other
behaviors it is passed through for possible future internal use by
`libp2p`.

Close #7264.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

R0-no-crate-publish-required The change does not require any crates to be re-published. T0-node This PR/Issue is related to the topic “node”.

Projects

Status: Blocked ⛔️

Development

Successfully merging this pull request may close these issues.

network/libp2p: Unhandled NewExternalAddrOfPeer libp2p event

3 participants