Merged
Conversation
skunert
added
R0-no-crate-publish-required
bkchr
approved these changes
May 30, 2025
lexnv
approved these changes
Jun 2, 2025
ordian
added a commit
that referenced
this pull request
Jun 4, 2025
* master: omni-node: fix `benchmark pallet` to work with `--runtime` (#8594) Handle and suppress "New unknown `FromSwarm` libp2p event" warning (#8731) Implement detailed logging for XCM failures (#8724) [pallet-revive] contract's nonce starts at 1 (#8734) sync/fix: Clear gap sync on known imported blocks (#8445) [PoP] Add personhood tracking pallets (#8164) client/net: Use litep2p as the default network backend (#8461) Unflake `returns_status_for_pruned_blocks` (#8709) [AHM] Report the weights of epmb pallet to expose kusama and polkadot weights (#8704) Remove all XCM dependencies from `pallet-revive` (#8584) Docker master image tag fix (#8711) Record ed as part of the storage deposit (#8718) [pallet-revive] update dry-run logic (#8662) feat: add collator peer ID to ParachainInherentData (#8708) Nest errors in pallet-xcm (#7730) pallet-assets ERC20 precompile (#8554) Broker: Introduce min price + adjust renewals to lower market. (#8630) [AHM] Staking async fixes for XCM and election planning (#8422) Staking (EPMB): Add defensive error handling to voter snapshot creation and solution verification (#8687)
pgherveou
pushed a commit
that referenced
this pull request
Jun 11, 2025
I was nearly dying of old age while trying to get CI to pass yesterday because of this test. Turns out there is a race condition (see code comment). The solution is a bit of a hack, but its the best one I came up with. Will let it run in a loop over the weekend, previously failed around once every 30-50 times when machine is put under stress.
alvicsam
pushed a commit
that referenced
this pull request
Oct 17, 2025
I was nearly dying of old age while trying to get CI to pass yesterday because of this test. Turns out there is a race condition (see code comment). The solution is a bit of a hack, but its the best one I came up with. Will let it run in a loop over the weekend, previously failed around once every 30-50 times when machine is put under stress.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was nearly dying of old age while trying to get CI to pass yesterday because of this test.
Turns out there is a race condition (see code comment). The solution is a bit of a hack, but its the best one I came up with.
Will let it run in a loop over the weekend, previously failed around once every 30-50 times when machine is put under stress.