Update features and feature dependencies#307
Conversation
ordian
left a comment
ordian
left a comment
There was a problem hiding this comment.
It doesn't seem like kvdb and kvdb-web require std feature of parity-util-mem, not sure if it matters though.
NikVolf
changed the title
|
I also moved SmallVec and fixed arrays implementations from ethereum feature (haven't realised they were there 🥺 |
NikVolf
force-pushed
the
nv-dep-fix
branch
2 times, most recently
from
4cfd69a to
a787090
Compare
Good catch! Might make sense to rename |
NikVolf
changed the title
There was a problem hiding this comment.
So I think that the point of having the "impls.rs" module was to keep malloc_size.rs updateable from upstream with less hassle. Now that we're maintaining it ourselves, I don't think it makes sense to keep it at all. With the latest commits here we removed the last non-test code and renamed the file, but now the module level docs are wrong and the file only contains a few tests + macro invocations.
Can we move the smallvec tests, and perhaps just put the macro invocation behind a cfg anmd remove the impls.rs?
|
@dvdplm I moved smallvec tests and updated docs having dedicated module for ethereum impls (now |
* master: (27 commits) update parity-util-mem (#309) Update features and feature dependencies (#307) Use proper memory queries to rocksdb (#308) Draft version updates and changelog (#299) Use custom error type for `from_hex` (#305) Fix typo. (#303) kvdb: remove KeyValueDBHandler (#304) extract common kvdb tests into a crate (#301) Expose to_hex and from_hex from impl-serde (#302) Add a top level function to parity-util-mem (#298) I/O statistic for key-value databases (#294) use for_tuples (#300) Add memory extensions for LRUCache, hashbrown (#293) Add memory stats for kvdb-s (#292) Provide #[derive(MallocSizeOf)] that is actually working (#291) Move and extend impls for locking primitives (#290) Update uint README (#288) Update README.md (#287) [ci]: remove feature flags in virtual workspace (#289) Prepare releases (#286) ...
* master: (56 commits) Remove libc completely (#333) update changelogs (#329) bump parity-util-mem to 0.4.2 (#328) remove libc feature from fixed-hash (#317) kvdb-rocksdb: release 0.4.2 (#327) kvdb-rocksdb: fix iter_from_prefix being slow (#326) MallocSizeOf for BTreeSet (#325) split off primitives (#323) travis: disable kvdb-web tests for chrome (#324) Expand const fn coverage (#319) uint: make zero const fn (#318) README: fix appveyor badge (#316) keccak-hash: switch benches to criterion (#315) update parity-util-mem (#309) Update features and feature dependencies (#307) Use proper memory queries to rocksdb (#308) Draft version updates and changelog (#299) Use custom error type for `from_hex` (#305) Fix typo. (#303) kvdb: remove KeyValueDBHandler (#304) ...
3 participants
No description provided.