Conversation
NikVolf
reviewed
Jan 2, 2020
dvdplm
approved these changes
Jan 2, 2020
Contributor
dvdplm
left a comment
dvdplm
left a comment
There was a problem hiding this comment.
LGTM modulo return value.
| bytes | ||
| } | ||
| } else if bytes.is_empty() { | ||
| return "0x".into() |
Contributor
There was a problem hiding this comment.
Suggested change
| return "0x".into() | |
| return "0x0".into() |
Contributor
Author
There was a problem hiding this comment.
But empty byte set (not uint) should be encoded as 0x not 0x0, vec![0] should have 0x00 encoding, one byte = two nibbles (always, since we don't trim zeros).
ordian
approved these changes
Jan 3, 2020
| /// | ||
| /// Returns an error if the string is not prefixed with `0x` | ||
| /// or non-hex characters are present. | ||
| pub fn from_hex(v: &str) -> Result<Vec<u8>, String> { |
Contributor
There was a problem hiding this comment.
I thought you were against String error types :P
Contributor
Author
There was a problem hiding this comment.
Yeah, you're right. I just simply extracted the method, but haven't thought of proper error type here. Let me do a follow up PR on this :)
dvdplm
added a commit
that referenced
this pull request
Jan 14, 2020
* master: (27 commits) update parity-util-mem (#309) Update features and feature dependencies (#307) Use proper memory queries to rocksdb (#308) Draft version updates and changelog (#299) Use custom error type for `from_hex` (#305) Fix typo. (#303) kvdb: remove KeyValueDBHandler (#304) extract common kvdb tests into a crate (#301) Expose to_hex and from_hex from impl-serde (#302) Add a top level function to parity-util-mem (#298) I/O statistic for key-value databases (#294) use for_tuples (#300) Add memory extensions for LRUCache, hashbrown (#293) Add memory stats for kvdb-s (#292) Provide #[derive(MallocSizeOf)] that is actually working (#291) Move and extend impls for locking primitives (#290) Update uint README (#288) Update README.md (#287) [ci]: remove feature flags in virtual workspace (#289) Prepare releases (#286) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the implementation is already there and we use
impl-serdeassp_core::bytesinsubstraterepo it makes sense to additionally expose "raw" (i.e. non-serde-specific)to_hex/from_hexmethods from that crate.Technically we could make it a separate crate (or we did already
rustc_hex?) but imho it makes sense to maintain it in a single place.Also this PR bumps minor version of
impl-serde, but does not change the versions of packages that depend on it, since no functionality is being changed there.