Move and extend impls for locking primitives#290
Merged
Conversation
NikVolf
force-pushed
the
nv-mem-utils
branch
from
8e4a408 to
1a39775
Compare
NikVolf
force-pushed
the
nv-mem-utils
branch
from
1a39775 to
07d0b8a
Compare
ordian
approved these changes
Dec 21, 2019
Contributor
ordian
left a comment
ordian
left a comment
There was a problem hiding this comment.
Should we remove "parking_lot" from ethereum-impls features?
https://github.com/paritytech/parity-common/pull/290/files#diff-a6e9f06585ce3cce1d6deea24a49aeb1R46
Looks good otherwise.
Contributor
Author
|
@ordian addressed |
Contributor
Author
|
@dvdplm pls add a 2nd review? |
dvdplm
suggested changes
Dec 30, 2019
Contributor
dvdplm
left a comment
dvdplm
left a comment
There was a problem hiding this comment.
Contributor
Author
|
@dvdplm I added comment, let me know if there is anything else I can do |
Contributor
We'll need to make a proper changelog entry but as there are several PRs in-flight atm I guess it's fine to do one pre-release PR where we write this down along all the rest. |
dvdplm
approved these changes
Dec 30, 2019
dvdplm
added a commit
that referenced
this pull request
Jan 14, 2020
* master: (27 commits) update parity-util-mem (#309) Update features and feature dependencies (#307) Use proper memory queries to rocksdb (#308) Draft version updates and changelog (#299) Use custom error type for `from_hex` (#305) Fix typo. (#303) kvdb: remove KeyValueDBHandler (#304) extract common kvdb tests into a crate (#301) Expose to_hex and from_hex from impl-serde (#302) Add a top level function to parity-util-mem (#298) I/O statistic for key-value databases (#294) use for_tuples (#300) Add memory extensions for LRUCache, hashbrown (#293) Add memory stats for kvdb-s (#292) Provide #[derive(MallocSizeOf)] that is actually working (#291) Move and extend impls for locking primitives (#290) Update uint README (#288) Update README.md (#287) [ci]: remove feature flags in virtual workspace (#289) Prepare releases (#286) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::sync::RwLockimpl was missing