Add memory stats for kvdb-s#292
Merged
Merged
Conversation
NikVolf
force-pushed
the
nv-mem-utils-3
branch
from
8237516 to
115541e
Compare
NikVolf
force-pushed
the
nv-mem-utils-3
branch
from
1185a45 to
70a4bd9
Compare
dvdplm
reviewed
Dec 30, 2019
dvdplm
approved these changes
Dec 31, 2019
Contributor
dvdplm
left a comment
dvdplm
left a comment
There was a problem hiding this comment.
lgtm modulo question about rocksdb.block-cache-usage
Contributor
|
Needs a rustfmt-run. |
NikVolf
force-pushed
the
nv-mem-utils-3
branch
from
8d617a5 to
74df358
Compare
ordian
reviewed
Dec 31, 2019
| indexed_db: SendWrapper<IdbDatabase>, | ||
| } | ||
|
|
||
| // TODO: implement when web-based implementation need memory stats |
ordian
approved these changes
Dec 31, 2019
Contributor
ordian
left a comment
ordian
left a comment
There was a problem hiding this comment.
Looks good modulo comments
NikVolf
force-pushed
the
nv-mem-utils-3
branch
from
dca3caa to
431f978
Compare
ordian
reviewed
Dec 31, 2019
ordian
reviewed
Dec 31, 2019
Co-Authored-By: Andronik Ordian <write@reusable.software>
dvdplm
added a commit
that referenced
this pull request
Jan 14, 2020
* master: (27 commits) update parity-util-mem (#309) Update features and feature dependencies (#307) Use proper memory queries to rocksdb (#308) Draft version updates and changelog (#299) Use custom error type for `from_hex` (#305) Fix typo. (#303) kvdb: remove KeyValueDBHandler (#304) extract common kvdb tests into a crate (#301) Expose to_hex and from_hex from impl-serde (#302) Add a top level function to parity-util-mem (#298) I/O statistic for key-value databases (#294) use for_tuples (#300) Add memory extensions for LRUCache, hashbrown (#293) Add memory stats for kvdb-s (#292) Provide #[derive(MallocSizeOf)] that is actually working (#291) Move and extend impls for locking primitives (#290) Update uint README (#288) Update README.md (#287) [ci]: remove feature flags in virtual workspace (#289) Prepare releases (#286) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
on top of #291