Compile triehash for no_std#280
Merged
Merged
Conversation
niklasad1
suggested changes
Dec 6, 2019
Contributor
niklasad1
left a comment
niklasad1
left a comment
There was a problem hiding this comment.
Looks good, but please update the CHANGELOG
niklasad1
approved these changes
Dec 6, 2019
Contributor
Author
|
@niklasad1 I'm having troubles with compiling this in substrate, so will move this back to inprogress. Sorry for disturbance :/ |
Contributor
Author
|
So, I've been compiling with |
ordian
approved these changes
Dec 6, 2019
Contributor
|
If you want to release it ASAP, please take a look at https://github.com/paritytech/parity-common/blob/master/CONTRIBUTING.md#releasing-a-new-version |
Contributor
|
https://travis-ci.org/paritytech/parity-common/jobs/621565021#L216-L220
|
dvdplm
added a commit
that referenced
this pull request
Dec 10, 2019
* master: Compile triehash for no_std (#280) [kvdb-rocksdb] Use "pinned" gets to avoid allocations (#274) [kvdb-rocksdb] Release 0.2 (#273) [kvdb-rocksdb] switch to upstream (#257) travis: try to fix wasmpack chrome test on macOS (#263) Use 2018 edition for rustfmt (#266) [fixed-hash]: re-export `alloc_` (#268) kvdb-web: async-awaitify (#259) kvdb-rocksdb: configurable memory budget per column (#256) Bump rlp crate version. (#270) Introduce Rlp::at_with_offset method. (#269) Make fixed-hash test structs public (#267) Migrate primitive types to 2018 edition (#262) upgrade tiny-keccak to 2.0 (#260)
dvdplm
added a commit
that referenced
this pull request
Dec 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea is to use this crate to compute
trie_root(transactions_receipts)in EthPoA -> Substrate bridge runtime module. The native version ofkeccak_256()is already available in Substrate => I hope most of timetrie_root()will spend in native code.Another option is to provide native ext
fn keccak_256_trie_root(), but since trie codec in Ethereum != trie codec in Substrate, it'll be calledfn ethereum_trie_root()&& I do not think that it is a good idea to have fn like that in Substrate. I'm open to suggestions, though.