travis: try to fix wasmpack chrome test on macOS#263
Conversation
|
Hmm, doesn't work. That's interesting. I'll check it tomorrow and will let you know, have to go now. |
|
|
dvdplm
left a comment
dvdplm
left a comment
There was a problem hiding this comment.
Changes look sane to me but I'm not sure how to actually test this. Any hints?
| install: | ||
| - curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.35.1/install.sh | sh | ||
| - source ~/.nvm/nvm.sh | ||
| - nvm install v10.5 |
There was a problem hiding this comment.
Is this the exact version we require here? It'd be nice to use the latest LTS (v12.13.1) if possible?
There was a problem hiding this comment.
v10.5 came here from my copy & paste of the old working .travis.yml. I think it's possible to use the latest LTS (not tested).
ordian
force-pushed
the
fix-wasmpack-macos
branch
from
c654740 to
6e3af8e
Compare
| } else { | ||
| None | ||
| }) | ||
| .and_then(|df_res| if df_res.status.success() { Some(df_res.stdout) } else { None }) |
There was a problem hiding this comment.
Is this a rustfmt change? I don't mind it, just curious.
There was a problem hiding this comment.
right, you can see it in the commit cargo fmt, otherwise ci was failing https://travis-ci.org/paritytech/parity-common/jobs/617128841#L217-L248
| initial_file_size: 256 * MB as u64, | ||
| block_size: 64 * KB, | ||
| } | ||
| CompactionProfile { initial_file_size: 256 * MB as u64, block_size: 64 * KB } |
There was a problem hiding this comment.
Is this a rustfmt change? I preferred the previous version but no big deal.
| 'a: 'view, | ||
| pub fn at_with_offset<'view>(&'view self, index: usize) -> Result<(Rlp<'a>, usize), DecoderError> | ||
| where | ||
| 'a: 'view, |
There was a problem hiding this comment.
Same. I like this formatting, but it has nothing to do with this PR.
…h/parity-common into ao-rocksdb-switch-to-upstream2 * 'ao-rocksdb-switch-to-upstream2' of github.com:paritytech/parity-common: kvdb-rocksdb: remove lz4 feature as it has no effect for now travis: try to fix wasmpack chrome test on macOS (#263) kvdb-rocksdb: please the CI kvdb-rocksdb: do not account for default column memory budget Use 2018 edition for rustfmt (#266) [fixed-hash]: re-export `alloc_` (#268) kvdb-web: async-awaitify (#259)
* master: Compile triehash for no_std (#280) [kvdb-rocksdb] Use "pinned" gets to avoid allocations (#274) [kvdb-rocksdb] Release 0.2 (#273) [kvdb-rocksdb] switch to upstream (#257) travis: try to fix wasmpack chrome test on macOS (#263) Use 2018 edition for rustfmt (#266) [fixed-hash]: re-export `alloc_` (#268) kvdb-web: async-awaitify (#259) kvdb-rocksdb: configurable memory budget per column (#256) Bump rlp crate version. (#270) Introduce Rlp::at_with_offset method. (#269) Make fixed-hash test structs public (#267) Migrate primitive types to 2018 edition (#262) upgrade tiny-keccak to 2.0 (#260)
4 participants
Should fix #226.