[kvdb-rocksdb] Add benchmark for point lookups#275
Merged
Conversation
ordian
reviewed
Dec 3, 2019
ordian
approved these changes
Dec 4, 2019
Contributor
ordian
left a comment
There was a problem hiding this comment.
Looks good as a starting point.
Contributor
Author
|
ping @niklasad1 |
niklasad1
reviewed
Dec 10, 2019
niklasad1
reviewed
Dec 10, 2019
niklasad1
reviewed
Dec 10, 2019
niklasad1
reviewed
Dec 10, 2019
niklasad1
reviewed
Dec 10, 2019
niklasad1
reviewed
Dec 10, 2019
niklasad1
approved these changes
Dec 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is far from perfect but might be a start of something. The tricky part of benchmarking databases is to setup the data set properly. This PR doesn't do anything particularly fancy but it's worth mentioning the basics:
iter_custom()rather thaniter().Benchmark results: