Skip to content

upgrade tiny-keccak to 2.0#260

Merged
ordian merged 3 commits into
masterfrom
ao-upgrade-tiny-keccak
Nov 13, 2019
Merged

upgrade tiny-keccak to 2.0#260
ordian merged 3 commits into
masterfrom
ao-upgrade-tiny-keccak

Conversation

@ordian
Copy link
Copy Markdown
Contributor

@ordian ordian commented Nov 12, 2019

No description provided.

@ordian ordian requested a review from debris November 12, 2019 15:04
ordian
ordian commented Nov 12, 2019
View reviewed changes
Comment thread keccak-hash/src/lib.rs Outdated
debris
debris reviewed Nov 12, 2019
View reviewed changes
Comment thread triehash/Cargo.toml Outdated
Comment thread keccak-hash/src/lib.rs Outdated
dvdplm
dvdplm approved these changes Nov 13, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any performance change you noticed?

@ordian
Copy link
Copy Markdown
Contributor Author

ordian commented Nov 13, 2019

No noticable perf change:
before

running 3 tests
test bench_keccak_256_with_empty_input   ... bench:         444 ns/iter (+/- 26)
test bench_keccak_256_with_large_input   ... bench:      13,405 ns/iter (+/- 573) = 305 MB/s
test bench_keccak_256_with_typical_input ... bench:         446 ns/iter (+/- 19) = 114 MB/s

after

running 3 tests
test bench_keccak_256_with_empty_input   ... bench:         447 ns/iter (+/- 2)
test bench_keccak_256_with_large_input   ... bench:      13,292 ns/iter (+/- 483) = 308 MB/s
test bench_keccak_256_with_typical_input ... bench:         449 ns/iter (+/- 22) = 113 MB/s

@ordian ordian merged commit 7eb170c into master Nov 13, 2019
@ordian ordian deleted the ao-upgrade-tiny-keccak branch November 13, 2019 12:26
ordian added a commit that referenced this pull request Nov 15, 2019
@ordian
Merge branch 'master' into ao-rocksdb-configurable-column-budget
dfaaf26 
* master:
  upgrade tiny-keccak to 2.0 (#260)
ordian added a commit that referenced this pull request Nov 22, 2019
@ordian
Merge branch 'master' into ao-rocksdb-switch-to-upstream2
1e1a865 
* master:
  Bump rlp crate version. (#270)
  Introduce Rlp::at_with_offset method. (#269)
  Make fixed-hash test structs public (#267)
  Migrate primitive types to 2018 edition (#262)
  upgrade tiny-keccak to 2.0 (#260)
dvdplm added a commit that referenced this pull request Dec 10, 2019
@dvdplm
Merge branch 'master' into dp/chore/secp256k1-from-upstream
12de906 
* master:
  Compile triehash for no_std (#280)
  [kvdb-rocksdb] Use "pinned" gets to avoid allocations (#274)
  [kvdb-rocksdb] Release 0.2 (#273)
  [kvdb-rocksdb] switch to upstream (#257)
  travis: try to fix wasmpack chrome test on macOS (#263)
  Use 2018 edition for rustfmt (#266)
  [fixed-hash]: re-export `alloc_` (#268)
  kvdb-web: async-awaitify (#259)
  kvdb-rocksdb: configurable memory budget per column (#256)
  Bump rlp crate version. (#270)
  Introduce Rlp::at_with_offset method. (#269)
  Make fixed-hash test structs public (#267)
  Migrate primitive types to 2018 edition (#262)
  upgrade tiny-keccak to 2.0 (#260)
@ordian ordian mentioned this pull request Jan 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@dvdplm dvdplm dvdplm approved these changes

@ascjones ascjones ascjones approved these changes

@debris debris debris approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-pleasereview M5-dependencies

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ordian @dvdplm @ascjones @debris