-
Notifications
You must be signed in to change notification settings - Fork 246
travis: try to fix wasmpack chrome test on macOS #263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
aa656c8
55b951d
77c6f6a
6e3af8e
f5e1bea
f054308
667d3b8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -112,11 +112,7 @@ impl CompactionProfile { | |
| let hdd_check_file = db_path | ||
| .to_str() | ||
| .and_then(|path_str| Command::new("df").arg(path_str).output().ok()) | ||
| .and_then(|df_res| if df_res.status.success() { | ||
| Some(df_res.stdout) | ||
| } else { | ||
| None | ||
| }) | ||
| .and_then(|df_res| if df_res.status.success() { Some(df_res.stdout) } else { None }) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this a rustfmt change? I don't mind it, just curious.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. right, you can see it in the commit
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. (rustfmt was enforced in #266) |
||
| .and_then(rotational_from_df_output); | ||
| // Read out the file and match compaction profile. | ||
| if let Some(hdd_check) = hdd_check_file { | ||
|
|
@@ -151,10 +147,7 @@ impl CompactionProfile { | |
|
|
||
| /// Slow HDD compaction profile | ||
| pub fn hdd() -> CompactionProfile { | ||
| CompactionProfile { | ||
| initial_file_size: 256 * MB as u64, | ||
| block_size: 64 * KB, | ||
| } | ||
| CompactionProfile { initial_file_size: 256 * MB as u64, block_size: 64 * KB } | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this a rustfmt change? I preferred the previous version but no big deal. |
||
| } | ||
| } | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -201,10 +201,9 @@ impl<'a> Rlp<'a> { | |
| /// raw data slice. | ||
| /// | ||
| /// Returns an error if this Rlp is not a list or if the index is out of range. | ||
| pub fn at_with_offset<'view>(&'view self, index: usize) | ||
| -> Result<(Rlp<'a>, usize), DecoderError> | ||
| where | ||
| 'a: 'view, | ||
| pub fn at_with_offset<'view>(&'view self, index: usize) -> Result<(Rlp<'a>, usize), DecoderError> | ||
| where | ||
| 'a: 'view, | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same. I like this formatting, but it has nothing to do with this PR. |
||
| { | ||
| if !self.is_list() { | ||
| return Err(DecoderError::RlpExpectedToBeList); | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.