Skip to content

chore(rpc): decouple op receipt response#8353

Merged
emhane merged 48 commits intomatt/scaffold-ethapifrom
emhane/rpc-build-receipts
May 27, 2024
Merged

chore(rpc): decouple op receipt response#8353
emhane merged 48 commits intomatt/scaffold-ethapifrom
emhane/rpc-build-receipts

Conversation

@emhane
Copy link
Collaborator

@emhane emhane commented May 22, 2024

  • Adds builder for RPC receipt response
  • Moves optimism response body extension logic to optimism crate
  • Removes deps dep:reth-evm-optimism and reth-evm-optimism/optimism from optimism feature in reth-rpc

rkrasiuk and others added 10 commits May 22, 2024 13:56
@emhane emhane added A-rpc Related to the RPC implementation A-op-reth Related to Optimism and op-reth labels May 22, 2024
@emhane emhane added S-blocked This cannot more forward until something else changes C-debt A clean up/refactor of existing code labels May 22, 2024
@emhane
Copy link
Collaborator Author

emhane commented May 22, 2024

blocked by matt/scaffold-ethapi which should be base, but isn't compiling yet, will change base when I got that code with skeleton code for type OpEthApi compiling

AbnerZheng and others added 11 commits May 22, 2024 21:47
@AbnerZheng @Rjected
feat: implement table range checksums for reth db checksum (#7623)
3eddaf3 
Co-authored-by: Dan Cline <6798349+Rjected@users.noreply.github.com>
@fgimenez
doc: remove missing link (#8363)
8158c28
@fgimenez
fix(storage): use u8 for NippiJar's DataReader::offset_size (#8360)
c5bc960
@Rjected
chore: improve HaveNotReceivedUpdatesForAWhile warning (#8356)
155876d
@mattsse @shekhirin
chore: clippy happy (#8362)
4250c33 
Co-authored-by: Alexey Shekhirin <a.shekhirin@gmail.com>
@mattsse
feat: add static-file-types (#8361)
f447db1
@Rjected
chore: make unknown block error lowercase (#8355)
3312dc2
@Rjected
chore: add docs for using personal tag in kurtosis (#8354)
b8eebbd
@jsvisa
chore(editor): set indent size=2 for the yaml files (#8366)
bc4dd37 
Signed-off-by: jsvisa <delweng@gmail.com>
@mattsse @DaniPopes
chore: remove network setup from config (#8364)
c73af62 
Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
@mattsse
chore: remove peer types dep (#8368)
a4933e7
mattsse
mattsse previously requested changes May 23, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this a lot as an initial step towards rpc abstraction

have a few nits

bsh98 and others added 16 commits May 24, 2024 09:54
@bsh98
fix(book): rethdb usage with op-node (#8375)
6df2b1c
@mattsse
chore: extract block execution errors (#8386)
9f61d18
@mattsse
chore(deps): rm reth-interfaces dep from reth-revm (#8387)
e0a9319
@mattsse
chore: remove wire-types optimism feature (#8383)
91f288d
@mattsse
chore: move sync to p2p crate (#8389)
4ee75d5
@mattsse
chore: simplify tree result types (#8390)
7892604
@rkrasiuk
chore(trie): account specific hashed storage cursor (#8377)
b06433c
@Rjected
chore: add 0BSD to deny.toml (#8391)
59622db
@guha-rahul
feat: implement clientVersionV1 in engine API (#8016)
a8e5eb6
@mattsse
chore: reorder struct account hashing struct defs (#8392)
46fd454
@mattsse
chore(deps): use error imports directly (#8388)
0056f2f
@wlawt @mattsse
refactor: extract init from node-core (#8373)
7dd7877 
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
@mattsse
chore: replace reth-interface usage (#8394)
df83bef
@mattsse
chore: remove rpc-layer dep (#8395)
a6cfa2c
@mattsse
chore: rm unused functions (#8396)
72f2f1b
@emhane
Make module for optimism tx rpc response
d1fb731
@emhane emhane requested a review from mattsse May 25, 2024 14:06
@emhane emhane changed the base branch from main to matt/scaffold-ethapi May 27, 2024 12:19
@emhane emhane removed the S-blocked This cannot more forward until something else changes label May 27, 2024
@emhane emhane dismissed mattsse’s stale review May 27, 2024 12:20

merging down to topic branch matt/scaffold-ethapi for further review

@emhane emhane merged commit 8a2379b into matt/scaffold-ethapi May 27, 2024
@emhane emhane deleted the emhane/rpc-build-receipts branch May 27, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

Assignees

No one assigned

Labels

A-op-reth Related to Optimism and op-reth A-rpc Related to the RPC implementation C-debt A clean up/refactor of existing code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Comments