fix(storage): use u8 for NippyJar's DataReader::offset_size#8360
Merged
fix(storage): use u8 for NippyJar's DataReader::offset_size#8360
Conversation
fgimenez
added
A-static-files
DaniPopes
approved these changes
May 23, 2024
mattsse
approved these changes
May 23, 2024
DaniPopes
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The size of an offset for NippyJar's
DataReaderis at most 8 bytes and we are using au64field for it. Besides being bigger than needed, there are unnecessary downcasts tousizethat could also be potentially lossy.In this PR the type of
offset_sizeis set tou8and there are non-lossy type casts tousizeandu64where needed.