Skip to content

docs: add panic comments in from_compact()#8346

Merged
mattsse merged 1 commit intomainfrom
fgimenez/compact-panic-comments
May 22, 2024
Merged

docs: add panic comments in from_compact()#8346
mattsse merged 1 commit intomainfrom
fgimenez/compact-panic-comments

Conversation

@fgimenez
Copy link
Member

These panics are not reachable unless there is an invalid database entry, this is not likely to occur. The doc comments state how and why these panics could occur.

@fgimenez fgimenez requested a review from gakonst as a code owner May 22, 2024 15:21
@shekhirin shekhirin added C-docs An addition or correction to our documentation A-db Related to the database labels May 22, 2024
@mattsse mattsse enabled auto-merge May 22, 2024 15:27
@mattsse mattsse added this pull request to the merge queue May 22, 2024
Merged via the queue into main with commit e2a5857 May 22, 2024
@mattsse mattsse deleted the fgimenez/compact-panic-comments branch May 22, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-db Related to the database C-docs An addition or correction to our documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments