Skip to content

chore: clippy happy#8362

Merged
mattsse merged 11 commits intomainfrom
matt/clippy-happy1214123322222223232
May 23, 2024
Merged

chore: clippy happy#8362
mattsse merged 11 commits intomainfrom
matt/clippy-happy1214123322222223232

Conversation

@mattsse
Copy link
Collaborator

@mattsse mattsse commented May 23, 2024

error: lint group `rust_2018_idioms` has the same priority (0) as a lint
   --> Cargo.toml:109:6
    |
108 | rust.unused_must_use = "deny"
    |      --------------- has the same priority as this lint
109 | rust.rust_2018_idioms = "deny"
    |      ^^^^^^^^^^^^^^^^   ------ has an implicit priority of 0
    |
    = note: the order of the lints in the table is ignored by Cargo
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority
    = note: `#[deny(clippy::lint_groups_priority)]` on by default
help: to have lints override the group set `rust_2018_idioms` to a lower priority
    |
109 | rust.rust_2018_idioms = { level = "deny", priority = -1 }

@mattsse mattsse requested a review from gakonst as a code owner May 23, 2024 09:51
@mattsse mattsse added the A-meta Changes in the contributor workflow and planning label May 23, 2024
@mattsse mattsse force-pushed the matt/clippy-happy1214123322222223232 branch 4 times, most recently from f71494d to 0e7fedd Compare May 23, 2024 10:06
@mattsse mattsse requested review from Rjected and emhane as code owners May 23, 2024 10:06
@mattsse mattsse force-pushed the matt/clippy-happy1214123322222223232 branch 2 times, most recently from 4f3f31a to 4f5977a Compare May 23, 2024 10:12
@mattsse mattsse force-pushed the matt/clippy-happy1214123322222223232 branch from 4f5977a to 87ab310 Compare May 23, 2024 10:14
@shekhirin
Copy link
Member

fixing more issues

@shekhirin shekhirin force-pushed the matt/clippy-happy1214123322222223232 branch from 6104ab3 to 8d3267c Compare May 23, 2024 10:47
//!
//! > "All components initialized"
//! once all components have been initialized and
//! > once all components have been initialized and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is wrong

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is correct?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess there should be a new line?
@shekhirin

@shekhirin shekhirin force-pushed the matt/clippy-happy1214123322222223232 branch from af088e9 to af4f5c5 Compare May 23, 2024 11:11
@mattsse mattsse merged commit 4250c33 into main May 23, 2024
@mattsse mattsse deleted the matt/clippy-happy1214123322222223232 branch May 23, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-meta Changes in the contributor workflow and planning

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments