Merged
Conversation
a1df559 to
bf578ca
Compare
cde60a1 to
cc5145a
Compare
Merging this PR will not alter performance
Comparing Footnotes
|
cc5145a to
95d5202
Compare
81ba6a8 to
f910cce
Compare
cc9c2b8 to
f910cce
Compare
Use serde_with::SerializeAs directly instead of From impl for ExExNotification serialization, matching how Chain handles its DeferredTrieData (which requires collecting owned data before borrowing).
mattsse
approved these changes
Jan 17, 2026
Restore reth-trie-common as unconditional dependency in execution-types and remove #[cfg(feature = "std")] from HashedPostState imports and hash_state_slow method.
mattsse
added a commit
that referenced
this pull request
Jan 17, 2026
Add no-std compatible lazy initialization wrapper for trie data: - SortedTrieData: Container bundling HashedPostStateSorted and TrieUpdatesSorted together - LazyTrieData: Lazily initialized wrapper supporting ready mode (immediate data) and deferred mode (computed on first access) These types provide a clean abstraction for lazy trie data without requiring the complexity of the reth-chain crate introduced in #21137. Amp-Thread-ID: https://ampcode.com/threads/T-019bc9ce-d450-7307-bc10-04dd112904f0 Co-authored-by: Amp <amp@ampcode.com>
mattsse
added a commit
that referenced
this pull request
Jan 17, 2026
This PR reverts #21137 (the reth-chain crate) and adds the useful LazyTrieData/SortedTrieData types directly to reth-trie-common. Changes: - Move Chain back to reth-execution-types - Move DeferredTrieData back to reth-chain-state - Remove the reth-chain crate - Add LazyTrieData and SortedTrieData to reth-trie-common The new types in reth-trie-common: - SortedTrieData: Container bundling HashedPostStateSorted + TrieUpdatesSorted - LazyTrieData: No-std compatible lazy wrapper with ready/deferred modes
mattsse
added a commit
that referenced
this pull request
Jan 17, 2026
This PR reverts #21137 (the reth-chain crate) and adds the useful LazyTrieData/SortedTrieData types directly to reth-trie-common. Changes: - Move Chain back to reth-execution-types - Move DeferredTrieData back to reth-chain-state - Remove the reth-chain crate - Add LazyTrieData and SortedTrieData to reth-trie-common The new types in reth-trie-common: - SortedTrieData: Container bundling HashedPostStateSorted + TrieUpdatesSorted - LazyTrieData: No-std compatible lazy wrapper with ready/deferred modes
mattsse
added a commit
that referenced
this pull request
Jan 17, 2026
This PR reverts #21137 (the reth-chain crate) and adds the useful LazyTrieData/SortedTrieData types directly to reth-trie-common. Changes: - Move Chain back to reth-execution-types - Move DeferredTrieData back to reth-chain-state - Remove the reth-chain crate - Add LazyTrieData and SortedTrieData to reth-trie-common The new types in reth-trie-common: - SortedTrieData: Container bundling HashedPostStateSorted + TrieUpdatesSorted - LazyTrieData: No-std compatible lazy wrapper with ready/deferred modes
mattsse
added a commit
that referenced
this pull request
Jan 17, 2026
This PR reverts #21137 (the reth-chain crate) and adds the useful LazyTrieData/SortedTrieData types directly to reth-trie-common. Changes: - Move Chain back to reth-execution-types - Move DeferredTrieData back to reth-chain-state - Remove the reth-chain crate - Add LazyTrieData and SortedTrieData to reth-trie-common The new types in reth-trie-common: - SortedTrieData: Container bundling HashedPostStateSorted + TrieUpdatesSorted - LazyTrieData: No-std compatible lazy wrapper with ready/deferred modes
Vui-Chee
added a commit
to okx/reth
that referenced
this pull request
Jan 20, 2026
* tag 'v1.10.1': (49 commits) chore: bump version to 1.10.1 (paradigmxyz#21188) chore: rename extend_ref methods on sorted data structures (paradigmxyz#21043) fix(flashblocks): Add flashblock ws connection retry period (paradigmxyz#20510) chore(bench): add --disable-tx-gossip to benchmark node args (paradigmxyz#21171) refactor(stages): reuse history index cache buffers in `collect_history_indices` (paradigmxyz#21017) feat(download): resumable snapshot downloads with auto-retry (paradigmxyz#21161) ci: update to tempoxyz (paradigmxyz#21176) chore: apply spelling and typo fixes (paradigmxyz#21182) docs: document minimal storage mode in pruning FAQ (paradigmxyz#21025) chore(deps): weekly `cargo update` (paradigmxyz#21167) feat(execution-types): add receipts_iter helper (paradigmxyz#21162) revert: undo Chain crate, add LazyTrieData to trie-common (paradigmxyz#21155) feat(engine): add new_payload_interval metric (start-to-start) (paradigmxyz#21159) feat(engine): add time_between_new_payloads metric (paradigmxyz#21158) fix(storage-api): gate reth-chain dependency behind std feature perf(storage): batch trie updates across blocks in save_blocks (paradigmxyz#21142) refactor: use ExecutionOutcome::single instead of tuple From (paradigmxyz#21152) chore(chain-state): reorganize deferred_trie.rs impl blocks (paradigmxyz#21151) feat(primitives-traits): add try_recover_signers for parallel batch recovery (paradigmxyz#21103) perf: make Chain use DeferredTrieData (paradigmxyz#21137) ...
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 22, 2026
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Feb 11, 2026
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes
Chainuse theDeferredTrieDatainstead ofHashedPostStateSortedandTrieUpdatesSorted.Key Changes
Chaintype now storesBTreeMap<BlockNumber, DeferredTrieData>instead of separate maps for trie updates and hashed stateChaincan be constructed without blocking on expensive trie computationsAccessing Trie Data
The trie data is still fully accessible, but access may block if background computation is in progress:
chain.trie_data()/chain.trie_data_at(num)- ReturnsDeferredTrieDatahandles (non-blocking)chain.trie_updates()/chain.trie_updates_at(num)- Blocks until computation completes, then returnsArc<TrieUpdatesSorted>chain.hashed_state()/chain.hashed_state_at(num)- Blocks until computation completes, then returnsArc<HashedPostStateSorted>For best performance, prefer using
trie_data()and callingwait_cloned()explicitly when you need the computed data.Crate Structure
A new
std-only cratereth-chainis added which contains:ChaintypeDeferredTrieDataandComputedTrieDataBackwards Compatibility
WAL files created with older versions (without trie data) will deserialize correctly - missing fields default to empty maps.