refactor: use ExecutionOutcome::single instead of tuple From#21152
Merged
refactor: use ExecutionOutcome::single instead of tuple From#21152
Conversation
Replace obfuscating tuple From conversions with explicit ExecutionOutcome::single() calls for better readability.
gakonst
approved these changes
Jan 17, 2026
Member
gakonst
left a comment
gakonst
left a comment
There was a problem hiding this comment.
LGTM! Clearer than the tuple From implementation.
DaniPopes
approved these changes
Jan 17, 2026
Vui-Chee
added a commit
to okx/reth
that referenced
this pull request
Jan 20, 2026
* tag 'v1.10.1': (49 commits) chore: bump version to 1.10.1 (paradigmxyz#21188) chore: rename extend_ref methods on sorted data structures (paradigmxyz#21043) fix(flashblocks): Add flashblock ws connection retry period (paradigmxyz#20510) chore(bench): add --disable-tx-gossip to benchmark node args (paradigmxyz#21171) refactor(stages): reuse history index cache buffers in `collect_history_indices` (paradigmxyz#21017) feat(download): resumable snapshot downloads with auto-retry (paradigmxyz#21161) ci: update to tempoxyz (paradigmxyz#21176) chore: apply spelling and typo fixes (paradigmxyz#21182) docs: document minimal storage mode in pruning FAQ (paradigmxyz#21025) chore(deps): weekly `cargo update` (paradigmxyz#21167) feat(execution-types): add receipts_iter helper (paradigmxyz#21162) revert: undo Chain crate, add LazyTrieData to trie-common (paradigmxyz#21155) feat(engine): add new_payload_interval metric (start-to-start) (paradigmxyz#21159) feat(engine): add time_between_new_payloads metric (paradigmxyz#21158) fix(storage-api): gate reth-chain dependency behind std feature perf(storage): batch trie updates across blocks in save_blocks (paradigmxyz#21142) refactor: use ExecutionOutcome::single instead of tuple From (paradigmxyz#21152) chore(chain-state): reorganize deferred_trie.rs impl blocks (paradigmxyz#21151) feat(primitives-traits): add try_recover_signers for parallel batch recovery (paradigmxyz#21103) perf: make Chain use DeferredTrieData (paradigmxyz#21137) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace obfuscating tuple
Fromconversions with explicitExecutionOutcome::single()calls inblocks_to_chainfor better readability.The tuple
From<(BlockExecutionOutput<T>, BlockNumber)>implementation just delegates toSelf::single(block_number, output), so calling the method directly is clearer.