Skip to content

chore(chain-state): reorganize deferred_trie.rs impl blocks#21151

Merged
mattsse merged 1 commit intomainfrom
chore/deferred-trie-reorg
Jan 17, 2026
Merged

chore(chain-state): reorganize deferred_trie.rs impl blocks#21151
mattsse merged 1 commit intomainfrom
chore/deferred-trie-reorg

Conversation

@mattsse
Copy link
Collaborator

@mattsse mattsse commented Jan 17, 2026

Move impl blocks to immediately follow their struct definitions for better code organization and readability.

  • impl Debug for DeferredTrieData and impl DeferredTrieData now follow DeferredTrieData struct
  • impl ComputedTrieData now follows ComputedTrieData struct

Copy link
Member

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - pure code organization refactor, no logic changes. impl blocks now follow their struct definitions for better readability.

⚠️ Note: There's a merge conflict that needs to be resolved before merging.

@github-project-automation github-project-automation bot moved this from Backlog to In Progress in Reth Tracker Jan 17, 2026
Move impl blocks to immediately follow their struct definitions for
better code organization and readability.
@mattsse mattsse force-pushed the chore/deferred-trie-reorg branch from 77c04dd to a2a937f Compare January 17, 2026 01:29
@mattsse mattsse enabled auto-merge January 17, 2026 01:30
@mattsse mattsse added the C-debt A clean up/refactor of existing code label Jan 17, 2026
@mattsse mattsse added this pull request to the merge queue Jan 17, 2026
Merged via the queue into main with commit 574bde0 Jan 17, 2026
43 of 44 checks passed
@mattsse mattsse deleted the chore/deferred-trie-reorg branch January 17, 2026 01:51
@github-project-automation github-project-automation bot moved this from In Progress to Done in Reth Tracker Jan 17, 2026
Vui-Chee added a commit to okx/reth that referenced this pull request Jan 20, 2026
* tag 'v1.10.1': (49 commits)
  chore: bump version to 1.10.1 (paradigmxyz#21188)
  chore: rename extend_ref methods on sorted data structures (paradigmxyz#21043)
  fix(flashblocks): Add flashblock ws connection retry period (paradigmxyz#20510)
  chore(bench): add --disable-tx-gossip to benchmark node args (paradigmxyz#21171)
  refactor(stages): reuse history index cache buffers in `collect_history_indices` (paradigmxyz#21017)
  feat(download): resumable snapshot downloads with auto-retry (paradigmxyz#21161)
  ci: update to tempoxyz (paradigmxyz#21176)
  chore: apply spelling and typo fixes (paradigmxyz#21182)
  docs: document minimal storage mode in pruning FAQ (paradigmxyz#21025)
  chore(deps): weekly `cargo update` (paradigmxyz#21167)
  feat(execution-types): add receipts_iter helper (paradigmxyz#21162)
  revert: undo Chain crate, add LazyTrieData to trie-common (paradigmxyz#21155)
  feat(engine): add new_payload_interval metric (start-to-start) (paradigmxyz#21159)
  feat(engine): add time_between_new_payloads metric (paradigmxyz#21158)
  fix(storage-api): gate reth-chain dependency behind std feature
  perf(storage): batch trie updates across blocks in save_blocks (paradigmxyz#21142)
  refactor: use ExecutionOutcome::single instead of tuple From (paradigmxyz#21152)
  chore(chain-state): reorganize deferred_trie.rs impl blocks (paradigmxyz#21151)
  feat(primitives-traits): add try_recover_signers for parallel batch recovery (paradigmxyz#21103)
  perf: make Chain use DeferredTrieData (paradigmxyz#21137)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-debt A clean up/refactor of existing code

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants