revert: undo Chain crate, add LazyTrieData to trie-common#21154
Closed
revert: undo Chain crate, add LazyTrieData to trie-common#21154
Conversation
mattsse
requested review from
Rjected,
klkvr,
mediocregopher and
shekhirin
as code owners
mattsse
requested review from
fgimenez,
joshieDo,
rakita and
yongkangc
as code owners
mattsse
force-pushed
the
mattsse/revert-21137
branch
from
675c701 to
6bf43ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR reverts #21137 (the
reth-chaincrate) and adds the usefulLazyTrieData/SortedTrieDatatypes directly toreth-trie-common.Why revert #21137?
The
reth-chaincrate introduced unnecessary complexity:Chainfromexecution-typesto a new crateDeferredTrieDatafromchain-stateto the new crateWhat this PR does
Chainstays inexecution-typeswith its original APILazyTrieDataandSortedTrieDatatoreth-trie-common- the useful types from the refactor, without the crate restructuringThe new types in
reth-trie-common:SortedTrieData: Container bundlingHashedPostStateSorted+TrieUpdatesSortedLazyTrieData: No-std compatible lazy wrapper with ready/deferred modesThese can be used in future optimizations without the architectural overhead of a separate crate.