chore(consensus): Add trait object error variant to ConsensusError#20875
Merged
chore(consensus): Add trait object error variant to ConsensusError#20875
ConsensusError#20875Conversation
) Close #481 Adds a `Custom` variant to `ConsensusError` that wraps an error trait object, following the same pattern as `DatabaseError` in #388. This enables type-safe error handling between `ConsensusError` and custom L2 error types without matching on error strings. Also removes `PartialEq` and `Eq` derives since `Arc<dyn Error>` can't implement them, and fixes affected tests in downloaders. cc @emhane --------- Co-authored-by: Emilia Hane <elsaemiliaevahane@gmail.com>
emhane
added
C-debt
mattsse
approved these changes
Jan 9, 2026
yongkangc
pushed a commit
that referenced
this pull request
Jan 12, 2026
…20875) Co-authored-by: leeli <Leeliren@proton.me>
yongkangc
pushed a commit
that referenced
this pull request
Jan 13, 2026
…20875) Co-authored-by: leeli <Leeliren@proton.me>
yongkangc
pushed a commit
that referenced
this pull request
Jan 13, 2026
…20875) Co-authored-by: leeli <Leeliren@proton.me>
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 22, 2026
…aradigmxyz/reth#20875) Co-authored-by: leeli <Leeliren@proton.me>
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Feb 11, 2026
…aradigmxyz/reth#20875) Co-authored-by: leeli <Leeliren@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstreams op-rs#492
Removes redundant
PartialEqandEqimpls forConsensusError, which were only used in tests, and addsConsensusError::Customvariant wrapping a trait object error.Follow up to #20843