Merged
Conversation
onbjerg
requested changes
Dec 16, 2022
Co-authored-by: Bjerg <onbjerg@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #492 +/- ##
==========================================
+ Coverage 73.18% 73.27% +0.08%
==========================================
Files 241 241
Lines 24169 24333 +164
==========================================
+ Hits 17689 17830 +141
- Misses 6480 6503 +23
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
emhane
added a commit
to JoshdfG/reth
that referenced
this pull request
Jan 5, 2026
…aradigmxyz#492) Close paradigmxyz#481 Adds a `Custom` variant to `ConsensusError` that wraps an error trait object, following the same pattern as `DatabaseError` in paradigmxyz#388. This enables type-safe error handling between `ConsensusError` and custom L2 error types without matching on error strings. Also removes `PartialEq` and `Eq` derives since `Arc<dyn Error>` can't implement them, and fixes affected tests in downloaders. cc @emhane --------- Co-authored-by: Emilia Hane <elsaemiliaevahane@gmail.com>
emhane
added a commit
that referenced
this pull request
Jan 9, 2026
) Close #481 Adds a `Custom` variant to `ConsensusError` that wraps an error trait object, following the same pattern as `DatabaseError` in #388. This enables type-safe error handling between `ConsensusError` and custom L2 error types without matching on error strings. Also removes `PartialEq` and `Eq` derives since `Arc<dyn Error>` can't implement them, and fixes affected tests in downloaders. cc @emhane --------- Co-authored-by: Emilia Hane <elsaemiliaevahane@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #488
when a peer falls below the banned threshold we should disconnect it and temporarily ban it.