chore(consensus): Add trait object error variant to ConsensusError

[LeeliRen6]

Close #481

Adds a Custom variant to ConsensusError that wraps an error trait object, following the same pattern as DatabaseError in #388. This enables type-safe error handling between ConsensusError and custom L2 error types without matching on error strings.

Also removes PartialEq and Eq derives since Arc<dyn Error> can't implement them, and fixes affected tests in downloaders.

cc @emhane

[emhane]

nice!

[emhane]

asides the smol comments about importing types in import prelude, as you're probably aware the remaining tests using equality of ConsensusError need fixing. use matches macro rule for this, see how it's done in #388. for example

assert_eq!(
             result.unwrap_err(),
            ConsensusError::BlobGasUsedDiff(GotExpected { got: DA_FOOTPRINT, expected: 0 })
);

becomes

assert!(
    matches!(
             result.unwrap_err(),
            ConsensusError::BlobGasUsedDiff(GotExpected { got, expected } if got == DA_FOOTPRINT && expected == 0)
    )
);

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.34%. Comparing base (a6a7ec5) to head (e1ee9c3).
⚠️ Report is 1 commits behind head on unstable.

Additional details and impacted files

Files with missing lines	Coverage Δ
crates/consensus/common/src/validation.rs	69.89% <ø> (ø)
crates/consensus/consensus/src/lib.rs	0.00% <ø> (ø)
crates/net/downloaders/src/file_client.rs	0.00% <ø> (ø)
...tes/net/downloaders/src/headers/reverse_headers.rs	13.90% <ø> (ø)
crates/net/downloaders/src/headers/task.rs	34.42% <ø> (ø)
crates/optimism/consensus/src/lib.rs	57.14% <ø> (ø)
crates/optimism/consensus/src/validation/mod.rs	43.08% <ø> (ø)

... and 7 files with indirect coverage changes

Flag	Coverage Δ
e2e	35.53% <ø> (+0.13%)	⬆️
unit	31.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
reth binary	54.44% <ø> (ø)
op historical proof	90.13% <ø> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[LeeliRen6]

Hi @emhane should be good this time

[emhane]

we don't want to change the logic, just the syntax. we still need to verify the error data in tests. see how it's done in 246a9c5

[LeeliRen6]

we don't want to change the logic, just the syntax. we still need to verify the error data in tests. see how it's done in 246a9c5

Thanks! Please have a look again.

[emhane]

nice!