chore(consensus): Remove associated type Consensus::Error#20843
Merged
Conversation
Closes #519 --------- Co-authored-by: Emilia Hane <elsaemiliaevahane@gmail.com> Co-authored-by: Emilia Hane <emiliaha95@gmail.com>
emhane
requested review from
Rjected,
mattsse and
mediocregopher
as code owners
mattsse
approved these changes
Jan 8, 2026
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
imo this makes sense
consensus error has
reth/crates/consensus/consensus/src/lib.rs
Lines 410 to 412 in b38d37a
which should be sufficient but perhaps we also add a dyn error variant here
wdyt @klkvr
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 22, 2026
…xyz/reth#20843) Co-authored-by: Josh_dfG <126518346+JoshdfG@users.noreply.github.com>
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Feb 11, 2026
…xyz/reth#20843) Co-authored-by: Josh_dfG <126518346+JoshdfG@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstreams op-rs#543
Removes redundant
Errorassociated type onConsensustrait