Skip to content

feat(ast): add AstBuilder::*_with_pure etc methods#9417

Merged
graphite-app[bot] merged 1 commit intomainfrom
02-27-feat_ast_add_astbuilder__with_pure_etc_methods
Mar 4, 2025
Merged

feat(ast): add AstBuilder::*_with_pure etc methods#9417
graphite-app[bot] merged 1 commit intomainfrom
02-27-feat_ast_add_astbuilder__with_pure_etc_methods

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Feb 27, 2025

Same as #6760. This PR aims to add a series of expression_*_with_* methods to solve

Expression::FunctionExpression(ctx.ast.alloc_function_with_scope_id(
arrow_function_expr.span,
FunctionType::FunctionExpression,
None,
false,
arrow_function_expr.r#async,
false,
arrow_function_expr.type_parameters,
NONE,
arrow_function_expr.params,
arrow_function_expr.return_type,
Some(body),
scope_id,
))

@Dunqing Dunqing changed the title feat(ast): add AstBuilder::*_with_pure etc methods feat(ast): add AstBuilder::*_with_pure etc methods Feb 27, 2025
Copy link
Member Author

Dunqing commented Feb 27, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-ast Area - AST A-ast-tools Area - AST tools C-enhancement Category - New feature or request A-linter Area - Linter labels Feb 27, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 27, 2025

CodSpeed Performance Report

Merging #9417 will not alter performance

Comparing 02-27-feat_ast_add_astbuilder__with_pure_etc_methods (59a9f1d) with main (934a387)

Summary

✅ 33 untouched benchmarks

@Dunqing Dunqing force-pushed the 02-27-feat_ast_add_astbuilder__with_pure_etc_methods branch 2 times, most recently from 35b6fb3 to 5c54b9c Compare February 27, 2025 16:30
@Dunqing Dunqing force-pushed the 02-27-feat_ast_add_astbuilder__with_pure_etc_methods branch 3 times, most recently from 6cab457 to 5042261 Compare March 4, 2025 01:23
@Dunqing
Copy link
Member Author

Dunqing commented Mar 4, 2025

I've discussed this PR with @overlookmotel last week, this is nice to have. So it is ok to merge without overlookmotel approval. Feel free to polish it later

@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Mar 4, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Mar 4, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 02-27-feat_ast_add_astbuilder__with_pure_etc_methods branch from 5042261 to 59a9f1d Compare March 4, 2025 06:13
@graphite-app graphite-app bot merged commit 59a9f1d into main Mar 4, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 02-27-feat_ast_add_astbuilder__with_pure_etc_methods branch March 4, 2025 06:18
@oxc-bot oxc-bot mentioned this pull request Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-ast Area - AST A-ast-tools Area - AST tools A-linter Area - Linter C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant