feat(ast): add AstBuilder::*_with_scope_id etc methods#6760
Merged
graphite-app[bot] merged 1 commit intomainfrom Oct 22, 2024
Merged
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @overlookmotel and the rest of your teammates on |
CodSpeed Performance ReportMerging #6760 will not alter performanceComparing Summary
|
Dunqing
approved these changes
Oct 22, 2024
Contributor
Merge activity
|
Add methods to `AstBuilder` to create AST nodes with `ScopeId`, `SymbolId`, `ReferenceId`, for use in transformer. e.g. `identifier_reference_with_reference_id`, `binding_identifier_with_symbol_id`, `block_statement_with_scope_id `.
Dunqing
force-pushed
the
10-21-feat_ast_add_astbuilder__with_scope_id_etc_methods
branch
from
83e8022 to
78fee6e
Compare
graphite-app
bot
deleted the
10-21-feat_ast_add_astbuilder__with_scope_id_etc_methods
branch
graphite-app bot
pushed a commit
that referenced
this pull request
Mar 4, 2025
Same as #6760. This PR aims to add a series of `expression_*_with_*` methods to solve https://github.com/oxc-project/oxc/blob/e7e4902617961f9d69039a1fefb278701e43bc94/crates/oxc_transformer/src/common/arrow_function_converter.rs#L651-L664
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add methods to
AstBuilderto create AST nodes withScopeId,SymbolId,ReferenceId, for use in transformer.e.g.
identifier_reference_with_reference_id,binding_identifier_with_symbol_id,block_statement_with_scope_id.