feat(transformer): add /* @_PURE__ */ annotation for pure calls

[Dunqing]

close: #6072

Many tests outputs are updated because we need to print /* @_PURE__ */ for the pure calls.

[Dunqing]

• feat(parser): apply pure to argument of unary expression #9530
• feat(transformer): add /* @_PURE__ */ annotation for pure calls #9424 👈 (View in Graphite)
• feat(ast): add AstBuilder::*_with_pure etc methods #9417
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Boshen]

It seems like we need to turn off comments in conformance codegen.

[codspeed-hq]

CodSpeed Performance Report

Merging #9424 will create unknown performance changes

_{Comparing 02-28-feat_transformer_add____pure_____annotation_for_pure_functions (45ace44) with main (59a9f1d)}

Summary

🆕 33 new benchmarks

Benchmarks breakdown

	Benchmark	BASE	HEAD	Change
🆕	codegen[checker.ts]	N/A	23.1 ms	N/A
🆕	codegen_sourcemap[checker.ts]	N/A	66.2 ms	N/A
🆕	isolated-declarations[vue-id.ts]	N/A	57.9 ms	N/A
🆕	lexer[RadixUIAdoptionSection.jsx]	N/A	20.8 µs	N/A
🆕	lexer[antd.js]	N/A	24.1 ms	N/A
🆕	lexer[cal.com.tsx]	N/A	5.7 ms	N/A
🆕	lexer[checker.ts]	N/A	14.5 ms	N/A
🆕	lexer[pdf.mjs]	N/A	3.8 ms	N/A
🆕	linter[RadixUIAdoptionSection.jsx]	N/A	2.7 ms	N/A
🆕	linter[cal.com.tsx]	N/A	1.2 s	N/A
🆕	linter[checker.ts]	N/A	2.9 s	N/A
🆕	mangler[antd.js]	N/A	16.1 ms	N/A
🆕	mangler[react.development.js]	N/A	297.7 µs	N/A
🆕	mangler[typescript.js]	N/A	39.8 ms	N/A
🆕	minifier[antd.js]	N/A	163 ms	N/A
🆕	minifier[react.development.js]	N/A	1.8 ms	N/A
🆕	minifier[typescript.js]	N/A	285.8 ms	N/A
🆕	estree[checker.ts]	N/A	91.8 ms	N/A
🆕	parser[RadixUIAdoptionSection.jsx]	N/A	88.9 µs	N/A
🆕	parser[antd.js]	N/A	111.9 ms	N/A
...	...	...	...	...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

[Dunqing]

It seems like we need to turn off comments in conformance codegen.

You mean turn off pure annotation comments? We need this to test if we added pure correctly. I found a lot of tests failed due to the way it is printed is not the same.

For example:

 var HelloMessage = React.createClass({ render: function() {
   return /* @__PURE__ */ React.createElement("div", null, "Hello ", this.props.name);
 } });
-React.render(
-  /* @__PURE__ */ React.createElement(HelloMessage, { name: /* @__PURE__ */ React.createElement("span", null, "Sebastian") }),
-  mountNode
-);
+React.render(/* @__PURE__ */ React.createElement(HelloMessage, { name: /* @__PURE__ */ React.createElement("span", null, "Sebastian") }), mountNode);

I will dig into this problem later.

[Boshen]

Feel free to merge after fixing the conformance issues.

[Dunqing]

Feel free to merge after fixing the conformance issues.

Fixed in #9530

[graphite-app]

Merge activity

• Mar 4, 1:12 AM EST: A user added this pull request to the Graphite merge queue.
• Mar 4, 1:23 AM EST: A user merged this pull request with the Graphite merge queue.