Skip to content

feat(parser): apply pure to argument of unary expression#9530

Merged
graphite-app[bot] merged 1 commit intomainfrom
03-04-fix_parser_apply_pure_to_argument_of_unary_expression
Mar 4, 2025
Merged

feat(parser): apply pure to argument of unary expression#9530
graphite-app[bot] merged 1 commit intomainfrom
03-04-fix_parser_apply_pure_to_argument_of_unary_expression

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Mar 4, 2025

Follow-up #9424

@github-actions github-actions bot added A-parser Area - Parser A-codegen Area - Code Generation C-bug Category - Bug labels Mar 4, 2025
Copy link
Member Author

Dunqing commented Mar 4, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dunqing Dunqing requested a review from Boshen March 4, 2025 03:29
@Dunqing Dunqing changed the title fix(parser): apply pure to argument of unary expression feat(parser): apply pure to argument of unary expression Mar 4, 2025
@github-actions github-actions bot added the C-enhancement Category - New feature or request label Mar 4, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 4, 2025

CodSpeed Performance Report

Merging #9530 will create unknown performance changes

Comparing 03-04-fix_parser_apply_pure_to_argument_of_unary_expression (2326cef) with main (45ace44)

Summary

🆕 33 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 codegen[checker.ts] N/A 23.1 ms N/A
🆕 codegen_sourcemap[checker.ts] N/A 66.2 ms N/A
🆕 isolated-declarations[vue-id.ts] N/A 57.9 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 20.9 µs N/A
🆕 lexer[antd.js] N/A 24.1 ms N/A
🆕 lexer[cal.com.tsx] N/A 5.7 ms N/A
🆕 lexer[checker.ts] N/A 14.5 ms N/A
🆕 lexer[pdf.mjs] N/A 3.8 ms N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.7 ms N/A
🆕 linter[cal.com.tsx] N/A 1.2 s N/A
🆕 linter[checker.ts] N/A 2.9 s N/A
🆕 mangler[antd.js] N/A 16.2 ms N/A
🆕 mangler[react.development.js] N/A 298 µs N/A
🆕 mangler[typescript.js] N/A 39.8 ms N/A
🆕 minifier[antd.js] N/A 163 ms N/A
🆕 minifier[react.development.js] N/A 1.8 ms N/A
🆕 minifier[typescript.js] N/A 285.8 ms N/A
🆕 estree[checker.ts] N/A 91.8 ms N/A
🆕 parser[RadixUIAdoptionSection.jsx] N/A 89 µs N/A
🆕 parser[antd.js] N/A 111.8 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Mar 4, 2025
Copy link
Member

Boshen commented Mar 4, 2025

Merge activity

  • Mar 4, 1:12 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 4, 1:12 AM EST: A user added this pull request to the Graphite merge queue.
  • Mar 4, 1:26 AM EST: A user merged this pull request with the Graphite merge queue.

@graphite-app graphite-app bot force-pushed the 02-28-feat_transformer_add____pure_____annotation_for_pure_functions branch from 7f62265 to 45ace44 Compare March 4, 2025 06:13
@graphite-app graphite-app bot requested a review from overlookmotel as a code owner March 4, 2025 06:13
@graphite-app graphite-app bot force-pushed the 03-04-fix_parser_apply_pure_to_argument_of_unary_expression branch from 829391e to 2326cef Compare March 4, 2025 06:14
Base automatically changed from 02-28-feat_transformer_add____pure_____annotation_for_pure_functions to main March 4, 2025 06:23
@graphite-app graphite-app bot merged commit 2326cef into main Mar 4, 2025
27 checks passed
@graphite-app graphite-app bot deleted the 03-04-fix_parser_apply_pure_to_argument_of_unary_expression branch March 4, 2025 06:26
@oxc-bot oxc-bot mentioned this pull request Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-codegen Area - Code Generation A-parser Area - Parser C-bug Category - Bug C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants