Skip to content

fix(linter): rule no-constant-binary-expression do not look into globals#9145

Merged
graphite-app[bot] merged 1 commit intomainfrom
02-15-ix_linter_rule_no-constant-binary-expression_do_not_look_into_globals_
Feb 15, 2025
Merged

fix(linter): rule no-constant-binary-expression do not look into globals#9145
graphite-app[bot] merged 1 commit intomainfrom
02-15-ix_linter_rule_no-constant-binary-expression_do_not_look_into_globals_

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented Feb 15, 2025

No description provided.

Copy link
Member Author

Sysix commented Feb 15, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 15, 2025

CodSpeed Performance Report

Merging #9145 will not alter performance

Comparing 02-15-ix_linter_rule_no-constant-binary-expression_do_not_look_into_globals_ (490c77d) with main (97cc1c8)

Summary

✅ 33 untouched benchmarks

@Sysix Sysix marked this pull request as ready for review February 15, 2025 15:04
@Boshen Boshen changed the base branch from 02-15-fix_linter_rule_promise_avoid-new_do_not_look_into_globals_ to graphite-base/9145 February 15, 2025 15:08
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Feb 15, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 15, 2025

Merge activity

@graphite-app graphite-app bot changed the base branch from graphite-base/9145 to main February 15, 2025 15:51
@graphite-app graphite-app bot force-pushed the 02-15-ix_linter_rule_no-constant-binary-expression_do_not_look_into_globals_ branch from 2ffdd7a to 490c77d Compare February 15, 2025 15:53
@graphite-app graphite-app bot merged commit 490c77d into main Feb 15, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 02-15-ix_linter_rule_no-constant-binary-expression_do_not_look_into_globals_ branch February 15, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant