Skip to content

fix(linter): rule no-constant-binary-expression do not look into globals #9145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Feb 15, 2025
Merged

fix(linter): rule no-constant-binary-expression do not look into globals #9145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions crates/oxc_linter/src/rules/eslint/no_constant_binary_expression.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,10 @@ impl NoConstantBinaryExpression {
Expression::CallExpression(call_expr) => {
if let Expression::Identifier(ident) = &call_expr.callee {
return ["Boolean", "String", "Number"].contains(&ident.name.as_str())
&& ctx.is_reference_to_global_variable(ident);
&& ctx
.scopes()
.root_unresolved_references()
.contains_key(ident.name.as_str());
}
false
}
Expand Down Expand Up @@ -291,13 +294,16 @@ impl NoConstantBinaryExpression {
},
Expression::CallExpression(call_expr) => {
if let Expression::Identifier(ident) = &call_expr.callee {
if ident.name == "String"
|| ident.name == "Number" && ctx.is_reference_to_global_variable(ident)
let unresolved_references = ctx.scopes().root_unresolved_references();
if (ident.name == "String" || ident.name == "Number")
&& unresolved_references.contains_key(ident.name.as_str())
{
return true;
}

if ident.name == "Boolean" && ctx.is_reference_to_global_variable(ident) {
if ident.name == "Boolean"
&& unresolved_references.contains_key(ident.name.as_str())
{
return call_expr
.arguments
.iter()
Expand Down Expand Up @@ -339,7 +345,10 @@ impl NoConstantBinaryExpression {
Expression::NewExpression(call_expr) => {
if let Expression::Identifier(ident) = &call_expr.callee {
return ctx.env_contains_var(ident.name.as_str())
&& ctx.is_reference_to_global_variable(ident);
&& ctx
.scopes()
.root_unresolved_references()
.contains_key(ident.name.as_str());
}
false
}
Expand Down
Loading