fix(linter): report no-console when the globals.console is off#9138
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 15, 2025
Conversation
Member
Author
CodSpeed Performance ReportMerging #9138 will not alter performanceComparing Summary
|
camchenry
approved these changes
Feb 15, 2025
This was referenced Feb 15, 2025
Contributor
Merge activity
|
…9138) It feels like looking into the globals is the right choice. Then we should report only when `console` is defined in `globals`, or in envs `browser, node, (service-)worker, ...`. I do not think the original rule looks into the globals: https://eslint.org/docs/latest/rules/no-console
7f21955 to
23d0d95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

It feels like looking into the globals is the right choice.
Then we should report only when
consoleis defined inglobals, or in envsbrowser, node, (service-)worker, ....I do not think the original rule looks into the globals:
https://eslint.org/docs/latest/rules/no-console