Skip to content

fix(linter): rule no-restricted-globals: do not check for globals entries#9139

Merged
graphite-app[bot] merged 1 commit intomainfrom
02-15-fix_linter_rule_no-restricted-globals_do_not_check_for_globals_entries
Feb 15, 2025
Merged

fix(linter): rule no-restricted-globals: do not check for globals entries#9139
graphite-app[bot] merged 1 commit intomainfrom
02-15-fix_linter_rule_no-restricted-globals_do_not_check_for_globals_entries

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented Feb 15, 2025

Same as no-console. The rule does not really check for globals:
https://eslint.org/docs/latest/rules/no-restricted-globals

Updated the tests to include the globals / envs configuration:
https://github.com/eslint/eslint/blob/main/tests/lib/rules/no-restricted-globals.js

Copy link
Member Author

Sysix commented Feb 15, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 15, 2025

CodSpeed Performance Report

Merging #9139 will not alter performance

Comparing 02-15-fix_linter_rule_no-restricted-globals_do_not_check_for_globals_entries (29141d6) with main (3576318)

Summary

✅ 33 untouched benchmarks

@Sysix Sysix marked this pull request as ready for review February 15, 2025 13:47
@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 15, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 02-15-fix_linter_report_no-console_when_the_globals.console_is_off_ branch from 7f21955 to 23d0d95 Compare February 15, 2025 15:04
@graphite-app graphite-app bot force-pushed the 02-15-fix_linter_rule_no-restricted-globals_do_not_check_for_globals_entries branch from d2d54e0 to 29141d6 Compare February 15, 2025 15:05
Base automatically changed from 02-15-fix_linter_report_no-console_when_the_globals.console_is_off_ to main February 15, 2025 15:12
@graphite-app graphite-app bot merged commit 29141d6 into main Feb 15, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 02-15-fix_linter_rule_no-restricted-globals_do_not_check_for_globals_entries branch February 15, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants