fix(linter): rule no-restricted-globals: do not check for globals entries#9139
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 15, 2025
Conversation
Member
Author
CodSpeed Performance ReportMerging #9139 will not alter performanceComparing Summary
|
camchenry
approved these changes
Feb 15, 2025
This was referenced Feb 15, 2025
Contributor
Merge activity
|
… entries (#9139) Same as `no-console`. The rule does not really check for globals: https://eslint.org/docs/latest/rules/no-restricted-globals Updated the tests to include the globals / envs configuration: https://github.com/eslint/eslint/blob/main/tests/lib/rules/no-restricted-globals.js
7f21955 to
23d0d95
Compare
d2d54e0 to
29141d6
Compare
Base automatically changed from
02-15-fix_linter_report_no-console_when_the_globals.console_is_off_
to
main
February 15, 2025 15:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Same as
no-console. The rule does not really check for globals:https://eslint.org/docs/latest/rules/no-restricted-globals
Updated the tests to include the globals / envs configuration:
https://github.com/eslint/eslint/blob/main/tests/lib/rules/no-restricted-globals.js