Skip to content

fix(linter): rule no-restricted-globals: do not check for globals entries #9139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Feb 15, 2025
Merged

fix(linter): rule no-restricted-globals: do not check for globals entries #9139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
92 changes: 64 additions & 28 deletions crates/oxc_linter/src/rules/eslint/no_restricted_globals.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ impl Rule for NoRestrictedGlobals {
return;
};

if ctx.is_reference_to_global_variable(ident) {
if ctx.scopes().root_unresolved_references().contains_key(ident.name.as_str()) {
ctx.diagnostic(no_restricted_globals(&ident.name, message, ident.span));
}
}
Expand All @@ -99,53 +99,89 @@ fn test() {
const CUSTOM_MESSAGE: &str = "Use bar instead.";

let pass = vec![
("foo", None),
("foo", Some(serde_json::json!(["bar"]))),
("var foo = 1;", Some(serde_json::json!(["foo"]))),
("event", Some(serde_json::json!(["bar"]))),
("import foo from 'bar';", Some(serde_json::json!(["foo"]))),
("function foo() {}", Some(serde_json::json!(["foo"]))),
("function fn() { var foo; }", Some(serde_json::json!(["foo"]))),
("foo.bar", Some(serde_json::json!(["bar"]))),
("foo", Some(serde_json::json!([{ "name": "bar", "message": "Use baz instead." }]))),
("foo", None, None),
("foo", Some(serde_json::json!(["bar"])), None),
("var foo = 1;", Some(serde_json::json!(["foo"])), None),
(
"event",
Some(serde_json::json!(["bar"])),
Some(serde_json::json!({ "env": { "browser": true }})),
),
("import foo from 'bar';", Some(serde_json::json!(["foo"])), None),
("function foo() {}", Some(serde_json::json!(["foo"])), None),
("function fn() { var foo; }", Some(serde_json::json!(["foo"])), None),
("foo.bar", Some(serde_json::json!(["bar"])), None),
("foo", Some(serde_json::json!([{ "name": "bar", "message": "Use baz instead." }])), None),
];

let fail = vec![
("foo", Some(serde_json::json!(["foo"]))),
("function fn() { foo; }", Some(serde_json::json!(["foo"]))),
("function fn() { foo; }", Some(serde_json::json!(["foo"]))),
("event", Some(serde_json::json!(["foo", "event"]))),
("foo", Some(serde_json::json!(["foo"]))),
("foo()", Some(serde_json::json!(["foo"]))),
("foo.bar()", Some(serde_json::json!(["foo"]))),
("foo", Some(serde_json::json!([{ "name": "foo" }]))),
("function fn() { foo; }", Some(serde_json::json!([{ "name": "foo" }]))),
("function fn() { foo; }", Some(serde_json::json!([{ "name": "foo" }]))),
("event", Some(serde_json::json!(["foo", { "name": "event" }]))),
("foo", Some(serde_json::json!([{ "name": "foo" }]))),
("foo()", Some(serde_json::json!([{ "name": "foo" }]))),
("foo.bar()", Some(serde_json::json!([{ "name": "foo" }]))),
("foo", Some(serde_json::json!([{ "name": "foo", "message": CUSTOM_MESSAGE }]))),
("foo", Some(serde_json::json!(["foo"])), None),
("function fn() { foo; }", Some(serde_json::json!(["foo"])), None),
("function fn() { foo; }", Some(serde_json::json!(["foo"])), None),
(
"event",
Some(serde_json::json!(["foo", "event"])),
Some(serde_json::json!({ "env": { "browser": true }})),
),
(
"foo",
Some(serde_json::json!(["foo"])),
Some(serde_json::json!({ "globals": { "foo": false }})),
),
("foo()", Some(serde_json::json!(["foo"])), None),
("foo.bar()", Some(serde_json::json!(["foo"])), None),
("foo", Some(serde_json::json!([{ "name": "foo" }])), None),
("function fn() { foo; }", Some(serde_json::json!([{ "name": "foo" }])), None),
(
"function fn() { foo; }",
Some(serde_json::json!([{ "name": "foo" }])),
Some(serde_json::json!({ "globals": { "foo": false }})),
),
(
"event",
Some(serde_json::json!(["foo", { "name": "event" }])),
Some(serde_json::json!({ "env": { "browser": true }})),
),
(
"foo",
Some(serde_json::json!([{ "name": "foo" }])),
Some(serde_json::json!({ "globals": { "foo": false }})),
),
("foo()", Some(serde_json::json!([{ "name": "foo" }])), None),
("foo.bar()", Some(serde_json::json!([{ "name": "foo" }])), None),
("foo", Some(serde_json::json!([{ "name": "foo", "message": CUSTOM_MESSAGE }])), None),
(
"function fn() { foo; }",
Some(serde_json::json!([{ "name": "foo", "message": CUSTOM_MESSAGE }])),
None,
),
(
"function fn() { foo; }",
Some(serde_json::json!([{ "name": "foo", "message": CUSTOM_MESSAGE }])),
Some(serde_json::json!({ "globals": { "foo": false }})),
),
(
"event",
Some(
serde_json::json!(["foo", { "name": "event", "message": "Use local event parameter." }]),
),
Some(serde_json::json!({ "env": { "browser": true }})),
),
(
"foo",
Some(serde_json::json!([{ "name": "foo", "message": CUSTOM_MESSAGE }])),
Some(serde_json::json!({ "globals": { "foo": false }})),
),
("foo()", Some(serde_json::json!([{ "name": "foo", "message": CUSTOM_MESSAGE }])), None),
(
"foo.bar()",
Some(serde_json::json!([{ "name": "foo", "message": CUSTOM_MESSAGE }])),
None,
),
("foo", Some(serde_json::json!([{ "name": "foo", "message": CUSTOM_MESSAGE }]))),
("foo()", Some(serde_json::json!([{ "name": "foo", "message": CUSTOM_MESSAGE }]))),
("foo.bar()", Some(serde_json::json!([{ "name": "foo", "message": CUSTOM_MESSAGE }]))),
(
"var foo = obj => hasOwnProperty(obj, 'name');",
Some(serde_json::json!(["hasOwnProperty"])),
None,
),
];

Expand Down
Loading