Skip to content

test(transformer): fix exec test reporter#7722

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-07-test_transformer_fix_exec_test_reporter
Dec 8, 2024
Merged

test(transformer): fix exec test reporter#7722
graphite-app[bot] merged 1 commit intomainfrom
12-07-test_transformer_fix_exec_test_reporter

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Dec 7, 2024

JsonReporter which the custom test reporter introduced in #7715 uses does not provide error message in message prop, where cause of failure is failing assertions. So tests failing due to failing assertions were omitted from snapshot. Include them.

Also add count of passing tests at top of the snapshot.

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 7, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Dec 7, 2024
@overlookmotel overlookmotel marked this pull request as ready for review December 7, 2024 17:50
@overlookmotel overlookmotel marked this pull request as draft December 7, 2024 17:54
@overlookmotel overlookmotel force-pushed the 12-07-test_transformer_fix_exec_test_reporter branch 3 times, most recently from 501b07e to 43686ed Compare December 7, 2024 18:36
@overlookmotel overlookmotel marked this pull request as ready for review December 7, 2024 18:39
@Dunqing Dunqing requested a review from Boshen December 8, 2024 01:39
@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 8, 2024

Merge activity

@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Dec 8, 2024
`JsonReporter` which the custom test reporter introduced in #7715 uses does not provide error message in `message` prop, where cause of failure is failing assertions. So tests failing due to failing assertions were omitted from snapshot. Include them.

Also add count of passing tests at top of the snapshot.
@Dunqing Dunqing force-pushed the 12-07-test_transformer_fix_exec_test_reporter branch from 43686ed to 65a1c31 Compare December 8, 2024 01:42
@graphite-app graphite-app bot merged commit 65a1c31 into main Dec 8, 2024
@graphite-app graphite-app bot deleted the 12-07-test_transformer_fix_exec_test_reporter branch December 8, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant