Skip to content

test(transformer/class-properties): override fixtures#7689

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-05-test_transformer_class-properties_override_fixtures
Dec 8, 2024
Merged

test(transformer/class-properties): override fixtures#7689
graphite-app[bot] merged 1 commit intomainfrom
12-05-test_transformer_class-properties_override_fixtures

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Dec 5, 2024

Override some transform conformance test fixtures for class properties transform, where:

  • Our output differs from Babel in cosmetic manner only.
  • Our transform intentionally works differently from Babel.
  • Babel's fixtures enable arrow functions transform, which malfunctions in our implementation. But we're not trying to test arrow functions transform here, so disable it.

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 5, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Dec 5, 2024
@overlookmotel overlookmotel force-pushed the 12-05-test_transformer_update_fixtures_script_support_overrides branch from 5eb208b to 0953eee Compare December 5, 2024 22:46
@overlookmotel overlookmotel force-pushed the 12-05-test_transformer_class-properties_override_fixtures branch from 118ff98 to 05e3be2 Compare December 5, 2024 22:46
@overlookmotel overlookmotel force-pushed the 12-05-test_transformer_update_fixtures_script_support_overrides branch from 0953eee to 05a1a76 Compare December 6, 2024 14:26
@overlookmotel overlookmotel force-pushed the 12-05-test_transformer_class-properties_override_fixtures branch from 05e3be2 to c0e731d Compare December 6, 2024 14:26
@overlookmotel overlookmotel force-pushed the 12-05-test_transformer_update_fixtures_script_support_overrides branch from 05a1a76 to d1ab894 Compare December 6, 2024 18:09
@overlookmotel overlookmotel force-pushed the 12-05-test_transformer_class-properties_override_fixtures branch from c0e731d to e346fc4 Compare December 6, 2024 18:09
@overlookmotel overlookmotel marked this pull request as ready for review December 6, 2024 18:16
@overlookmotel overlookmotel force-pushed the 12-05-test_transformer_update_fixtures_script_support_overrides branch from d1ab894 to 13881e6 Compare December 7, 2024 18:59
@overlookmotel overlookmotel force-pushed the 12-05-test_transformer_class-properties_override_fixtures branch from e346fc4 to aca4fd0 Compare December 7, 2024 18:59
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Dec 8, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 8, 2024

Merge activity

Override some transform conformance test fixtures for class properties transform, where:

* Our output differs from Babel in cosmetic manner only.
* Our transform intentionally works differently from Babel.
* Babel's fixtures enable arrow functions transform, which malfunctions in our implementation. But we're not trying to test arrow functions transform here, so disable it.
@Dunqing Dunqing force-pushed the 12-05-test_transformer_update_fixtures_script_support_overrides branch from 13881e6 to efaaa97 Compare December 8, 2024 01:43
@Dunqing Dunqing force-pushed the 12-05-test_transformer_class-properties_override_fixtures branch from aca4fd0 to 5fd1361 Compare December 8, 2024 01:43
Base automatically changed from 12-05-test_transformer_update_fixtures_script_support_overrides to main December 8, 2024 02:02
@graphite-app graphite-app bot merged commit 5fd1361 into main Dec 8, 2024
@graphite-app graphite-app bot deleted the 12-05-test_transformer_class-properties_override_fixtures branch December 8, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant