Skip to content

test(transformer): update fixtures script support overrides#7688

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-05-test_transformer_update_fixtures_script_support_overrides
Dec 8, 2024
Merged

test(transformer): update fixtures script support overrides#7688
graphite-app[bot] merged 1 commit intomainfrom
12-05-test_transformer_update_fixtures_script_support_overrides

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Dec 5, 2024

Support overriding test fixtures in update_fixtures.js script.

Any files in tasks/transform_conformance/overrides are copied into Babel test fixtures. If options.json is overridden, then script runs Babel with updated options, to generate a new output file for the fixture.

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 5, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Dec 5, 2024
@github-actions github-actions bot added the C-test Category - Testing. Code is missing test cases, or a PR is adding them label Dec 5, 2024
@overlookmotel overlookmotel force-pushed the 12-05-test_transformer_update_fixtures_script_support_overrides branch 3 times, most recently from 05a1a76 to d1ab894 Compare December 6, 2024 18:09
@overlookmotel overlookmotel marked this pull request as ready for review December 6, 2024 18:12
@overlookmotel overlookmotel force-pushed the 12-05-test_transformer_update_fixtures_script_support_overrides branch from d1ab894 to 13881e6 Compare December 7, 2024 18:59
@overlookmotel overlookmotel changed the base branch from main to 12-05-test_transformer_class-properties_exec_test_for_this_in_computed_key December 7, 2024 18:59
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Dec 8, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 8, 2024

Merge activity

Support overriding test fixtures in `update_fixtures.js` script.

Any files in `tasks/transform_conformance/overrides` are copied into Babel test fixtures. If `options.json` is overridden, then script runs Babel with updated options, to generate a new `output` file for the fixture.
@Dunqing Dunqing force-pushed the 12-05-test_transformer_class-properties_exec_test_for_this_in_computed_key branch from cda9512 to da63e87 Compare December 8, 2024 01:42
@Dunqing Dunqing force-pushed the 12-05-test_transformer_update_fixtures_script_support_overrides branch from 13881e6 to efaaa97 Compare December 8, 2024 01:43
Dunqing pushed a commit that referenced this pull request Dec 8, 2024
…res (#7713)

Add `just update-transformer-fixtures` to update transformer conformance tests with overrides (see #7688).
Base automatically changed from 12-05-test_transformer_class-properties_exec_test_for_this_in_computed_key to main December 8, 2024 01:57
@graphite-app graphite-app bot merged commit efaaa97 into main Dec 8, 2024
@graphite-app graphite-app bot deleted the 12-05-test_transformer_update_fixtures_script_support_overrides branch December 8, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant