refactor(transformer/class-properties)!: rename ClassPropertiesOptions::loose

[overlookmotel]

loose option also covers the private_fields_as_properties assumption, not only set_public_class_fields.

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[overlookmotel]

• feat(transformer/class-properties): support private_fields_as_properties assumption #7717
• refactor(transformer/class-properties)!: rename ClassPropertiesOptions::loose #7716 👈 (View in Graphite)
• test(transformer): add just script to update transformer test fixtures #7713
• test(transformer): fix merging options in fixtures update script #7712
• refactor(transformer/class-properties): TODO comments for future optimizations #7711
• refactor(transformer/class-properties): shorten output when _super function #7710
• fix(transformer/class-properties): fix SymbolFlags for _super function #7709
• fix(transformer/class-properties): make _super function outside class strict mode #7708
• test(transformer/class-properties): override fixtures #7689
• test(transformer): update fixtures script support overrides #7688
• test(transformer/class-properties): exec test for this in computed key #7687
• test(transformer): fix exec test reporter #7722
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #7716 will not alter performance

_{Comparing 12-07-refactor_transformer_class-properties_rename_classpropertiesoptions_loose_ (5913200) with main (ad27b20)}

Summary

✅ 29 untouched benchmarks

[Dunqing]

I was thinking that we are only compatible with Babel8, so do we still need to support the loose option?

[overlookmotel]

I was thinking that we are only compatible with Babel8, so do we still need to support the loose option?

I don't know what Babel 8 supports and doesn't support. But loose is equivalent to set_public_class_fields + private_fields_as_properties assumptions, which we do want to support. And we need loose at least in our test infra, because Babel's fixtures use it.

[Dunqing]

I don't know what Babel 8 supports and doesn't support. But loose is equivalent to set_public_class_fields + private_fields_as_properties assumptions, which we do want to support. And we need loose at least in our test infra, because Babel's fixtures use it.

Yes, I know we can override the config to enable set_public_class_fields + private_fields_as_properties instead of loose, anyway, we can keep it for now.

[Dunqing]

Merge activity

• Dec 7, 8:40 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Dec 7, 8:40 PM EST: A user added this pull request to the Graphite merge queue.
• Dec 7, 9:21 PM EST: A user merged this pull request with the Graphite merge queue.