refactor(var-declarations): remove unnecessary init parameter from insert_var

[Dunqing]

If we want to pass init, we should use insert_var_with_init

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[Dunqing]

• refactor(transformer): rename VarDeclarationsStore methods #7682
• refactor(var-declarations): remove unnecessary init parameter from insert_var #7668 👈 (View in Graphite)
• feat(transformer/var-declarations): add insert_var_with_init method #7667
• refactor(transformer): use ctx.var_declarations.create_var* methods #7666
• feat(transformer/var-declaration): add a series of create_var* methods #7665
• feat(traverse): add TraverseCtx::generate_uid_in_current_hoist_scope_based_on_node #7642
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #7668 will not alter performance

_{Comparing 12-05-refactor_var-declarations_remove_unnecessary_init_parameter_from_insert_var (3d593ec) with main (0ca10e2)}

Summary

✅ 29 untouched benchmarks

[overlookmotel]

This is all great. So much boilerplate code removed.

Thanks for splitting it into many small PRs - made it much easier to review.

[overlookmotel]

Oh bollocks. I screwed up and rebased this on main by accident. Oops! I'll sort it out once the downstack PRs are all merged.

[overlookmotel]

Merge activity

• Dec 5, 9:27 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Dec 5, 9:33 AM EST: A user added this pull request to the Graphite merge queue.
• Dec 5, 9:46 AM EST: A user merged this pull request with the Graphite merge queue.