Skip to content

refactor(transformer): use ctx.var_declarations.create_var* methods#7666

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-05-refactor_transformer_use_var_declaration_create_var_methods
Dec 5, 2024
Merged

refactor(transformer): use ctx.var_declarations.create_var* methods#7666
graphite-app[bot] merged 1 commit intomainfrom
12-05-refactor_transformer_use_var_declaration_create_var_methods

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Dec 5, 2024 •
edited
Loading

It turns out these APIs are very useful, we remove many boilerplate code.

This was referenced Dec 5, 2024
Merged
Merged
@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 5, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@Dunqing Graphite App
Copy link
Member Author

Dunqing commented Dec 5, 2024 •
edited by overlookmotel
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dunqing Dunqing changed the title refactor(transformer): use var_declaration::create_var* methods refactor(transformer): use var_declaration::create_var* methods Dec 5, 2024
@Dunqing Dunqing changed the title refactor(transformer): use var_declaration::create_var* methods refactor(transformer): use ctx.var_declarations::create_var* methods Dec 5, 2024
@Dunqing Dunqing changed the title refactor(transformer): use ctx.var_declarations::create_var* methods refactor(transformer): use ctx.var_declarations.create_var* methods Dec 5, 2024
@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Dec 5, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 5, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #7666 will not alter performance

Comparing 12-05-refactor_transformer_use_var_declaration_create_var_methods (0ca10e2) with main (4e489bd)

Summary

✅ 29 untouched benchmarks

This was referenced Dec 5, 2024
Merged
Merged
@Dunqing Dunqing force-pushed the 12-05-refactor_transformer_use_var_declaration_create_var_methods branch from 173a5eb to f437658 Compare December 5, 2024 03:57
@overlookmotel overlookmotel force-pushed the 12-05-feat_transformer_var-declaration_add_create_var_methods branch 2 times, most recently from 2895b34 to eb275dd Compare December 5, 2024 13:47
@overlookmotel overlookmotel force-pushed the 12-05-refactor_transformer_use_var_declaration_create_var_methods branch from f437658 to 5e17bb8 Compare December 5, 2024 13:47
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Dec 5, 2024
@overlookmotel Graphite App
Copy link
Member

overlookmotel commented Dec 5, 2024 •
edited by graphite-app bot
Loading

Merge activity

  • Dec 5, 8:52 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 5, 8:53 AM EST: A user added this pull request to the Graphite merge queue.
  • Dec 5, 9:03 AM EST: The Graphite merge queue couldn't merge this PR because it had conflicts with the trunk branch.
  • Dec 5, 9:30 AM EST: A user added this pull request to the Graphite merge queue.
  • Dec 5, 9:36 AM EST: A user merged this pull request with the Graphite merge queue.

@overlookmotel overlookmotel changed the base branch from 12-05-feat_transformer_var-declaration_add_create_var_methods to graphite-base/7666 December 5, 2024 13:53
overlookmotel pushed a commit that referenced this pull request Dec 5, 2024
@Dunqing
feat(transformer/var-declaration): add a series of create_var* meth…
8705a29 
…ods (#7665)

part of #7666.

These methods aim to combine generate binding and insert var into one method.
@graphite-app graphite-app bot changed the base branch from graphite-base/7666 to main December 5, 2024 14:02
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 5, 2024
@Dunqing Dunqing force-pushed the 12-05-refactor_transformer_use_var_declaration_create_var_methods branch from 5e17bb8 to 7804ffe Compare December 5, 2024 14:20
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Dec 5, 2024
@overlookmotel overlookmotel force-pushed the 12-05-refactor_transformer_use_var_declaration_create_var_methods branch from 7804ffe to a57067f Compare December 5, 2024 14:24
@overlookmotel overlookmotel mentioned this pull request Dec 5, 2024
Merged
@Dunqing
refactor(transformer): use ctx.var_declarations.create_var* methods (…
0ca10e2 
…#7666)

It turns out these APIs are very useful, we remove many boilerplate code.
@overlookmotel overlookmotel force-pushed the 12-05-refactor_transformer_use_var_declaration_create_var_methods branch from a57067f to 0ca10e2 Compare December 5, 2024 14:31
@graphite-app graphite-app bot merged commit 0ca10e2 into main Dec 5, 2024
@graphite-app graphite-app bot deleted the 12-05-refactor_transformer_use_var_declaration_create_var_methods branch December 5, 2024 14:36
@oxc-bot oxc-bot mentioned this pull request Dec 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@overlookmotel overlookmotel overlookmotel approved these changes

Assignees

No one assigned

Labels

0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Dunqing @overlookmotel