Skip to content

feat(transformer/var-declaration): add a series of create_var* methods#7665

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-05-feat_transformer_var-declaration_add_create_var_methods
Dec 5, 2024
Merged

feat(transformer/var-declaration): add a series of create_var* methods#7665
graphite-app[bot] merged 1 commit intomainfrom
12-05-feat_transformer_var-declaration_add_create_var_methods

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Dec 5, 2024

part of #7666.

These methods aim to combine generate binding and insert var into one method.

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 5, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@Dunqing Dunqing changed the title feat(transformer/var-declaration): add create_var* methods feat(transformer/var-declaration): add a series of create_var* methods Dec 5, 2024
@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request labels Dec 5, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 5, 2024

CodSpeed Performance Report

Merging #7665 will degrade performances by 3.07%

Comparing 12-05-feat_transformer_var-declaration_add_create_var_methods (8705a29) with main (ff73c7f)

Summary

❌ 1 regressions
✅ 28 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main 12-05-feat_transformer_var-declaration_add_create_var_methods Change
semantic[RadixUIAdoptionSection.jsx] 74.2 µs 76.5 µs -3.07%

@overlookmotel overlookmotel changed the base branch from 12-04-feat_traverse_add_traversectx_generate_uid_in_current_hoist_scope_based_on_node to graphite-base/7665 December 5, 2024 13:41
@overlookmotel overlookmotel force-pushed the 12-05-feat_transformer_var-declaration_add_create_var_methods branch from a97e6aa to 2895b34 Compare December 5, 2024 13:46
@overlookmotel overlookmotel changed the base branch from graphite-base/7665 to main December 5, 2024 13:47
@overlookmotel overlookmotel force-pushed the 12-05-feat_transformer_var-declaration_add_create_var_methods branch from 2895b34 to eb275dd Compare December 5, 2024 13:47
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Dec 5, 2024
Copy link
Member

overlookmotel commented Dec 5, 2024

Merge activity

  • Dec 5, 8:51 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 5, 8:52 AM EST: A user added this pull request to the Graphite merge queue.
  • Dec 5, 9:02 AM EST: A user merged this pull request with the Graphite merge queue.

…ods (#7665)

part of #7666.

These methods aim to combine generate binding and insert var into one method.
@overlookmotel overlookmotel force-pushed the 12-05-feat_transformer_var-declaration_add_create_var_methods branch from eb275dd to 8705a29 Compare December 5, 2024 13:53
@graphite-app graphite-app bot merged commit 8705a29 into main Dec 5, 2024
@graphite-app graphite-app bot deleted the 12-05-feat_transformer_var-declaration_add_create_var_methods branch December 5, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants