Skip to content

feat(traverse): add TraverseCtx::generate_uid_in_current_hoist_scope_based_on_node#7642

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-04-feat_traverse_add_traversectx_generate_uid_in_current_hoist_scope_based_on_node
Dec 5, 2024
Merged

feat(traverse): add TraverseCtx::generate_uid_in_current_hoist_scope_based_on_node#7642
graphite-app[bot] merged 1 commit intomainfrom
12-04-feat_traverse_add_traversectx_generate_uid_in_current_hoist_scope_based_on_node

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Dec 4, 2024

We have a lot of usage for this API in class-properties

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 4, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the C-enhancement Category - New feature or request label Dec 4, 2024
@Dunqing Dunqing changed the title feat(traverse): add TraverseCtx::generate_uid_in_current_hoist_scope_based_on_node feat(traverse): add TraverseCtx::generate_uid_in_current_hoist_scope_based_on_node Dec 4, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 4, 2024

CodSpeed Performance Report

Merging #7642 will not alter performance

Comparing 12-04-feat_traverse_add_traversectx_generate_uid_in_current_hoist_scope_based_on_node (ff73c7f) with main (3de4a43)

Summary

✅ 29 untouched benchmarks

@overlookmotel overlookmotel added A-transformer Area - Transformer / Transpiler 0-merge Merge with Graphite Merge Queue labels Dec 5, 2024
Copy link
Member

overlookmotel commented Dec 5, 2024

Merge activity

  • Dec 5, 8:41 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 5, 8:41 AM EST: A user added this pull request to the Graphite merge queue.
  • Dec 5, 8:46 AM EST: A user merged this pull request with the Graphite merge queue.

…_based_on_node` (#7642)

We have a lot of usage for this API in `class-properties`
@overlookmotel overlookmotel force-pushed the 12-04-feat_traverse_add_traversectx_generate_uid_in_current_hoist_scope_based_on_node branch from af0a4f2 to ff73c7f Compare December 5, 2024 13:41
@graphite-app graphite-app bot merged commit ff73c7f into main Dec 5, 2024
@graphite-app graphite-app bot deleted the 12-04-feat_traverse_add_traversectx_generate_uid_in_current_hoist_scope_based_on_node branch December 5, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants