feat(linter): support `overrides` config field by DonIsaac · Pull Request #6974 · oxc-project/oxc

DonIsaac · 2024-10-28T01:31:31Z

Part of #5653

graphite-app · 2024-10-28T01:31:36Z

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

DonIsaac · 2024-10-28T01:31:45Z

feat(linter): support overrides config field #6974 👈
refactor(linter): move LintPlugins from LintOptions to LintConfig #6932
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @DonIsaac and the rest of your teammates on Graphite

crates/oxc_linter/Cargo.toml

crates/oxc_linter/src/config/flat.rs

DonIsaac · 2024-10-28T02:32:55Z

Benchmarking on an internal codebase, I'm seeing a roughly 14% perf degredation with a single override that uses 4 glob patterns.

Config file:

{
  "categories": {
    "correctness": "error",
    "suspicious": "warn"
  },
  "rules": {
    "oxc/no-accumulating-spread": "warn"
  },
  "overrides": [
    {
      "files": ["*.spec.ts", "*.spec.tsx", "*.test.ts", "*.test.tsx"],
      "rules": {
        "oxc/no-accumulating-spread": "off",
        "@typescript-eslint/no-explicit-any": "off",
        "no-unused-vars": "off"
      }
    }
  ]
}

DonIsaac · 2024-10-28T03:32:04Z

Still needs tests. I'll add those tomorrow.

codspeed-hq · 2024-10-28T03:40:32Z

CodSpeed Performance Report

Merging #6974 will not alter performance

_{Comparing don/10-27-feat_linter_support_overrides_config_field (2268a0e) with main (c6a4868)}

Summary

✅ 30 untouched benchmarks

Boshen

I'll test this locally.

camchenry · 2024-10-28T14:03:42Z

Benchmarking on an internal codebase, I'm seeing a roughly 14% perf degredation with a single override that uses 4 glob patterns.

I wonder how much of that is related to just reading the config file? What happens if you pass -c to both binaries, but one doesn't have an override.

Nothing sticks out at me as being extremely slow here, I think I'd need to dive in and do some profiling first.

Boshen

I see we have a bit of refactoring going on in this PR, I'd try and get them merged first.

Boshen

We also need integration tests in

oxc/apps/oxlint/src/lint.rs

Line 237 in 2a57a66

mod test {

closes #194 Long way for the goal: - [x] support simple "rules" block - [x] support simple "categories" block - [x] support simple "plugins" block - [x] support "categories" on, and "rules" off * - [x] support "plugins" on, and "rules off * - [x] numbers instead of `off`, `warn` or `error` - [x] configuration array like: `no-magic_numbers: ["off", {...}]` - [x] filter rules which are not enabled by plugin - [x] all other wierd combinations - [x] enable eslint always - [x] check import from `../scripts` folder in build file - [x] support jsonc / comments in files - [x] prepare for overrides oxc-project/oxc#6974 - [x] Docs - [x] more tests - [x] test rules count with oxlint command - [x] ~~depends on oxc-project/oxc#6896 workaround in tests - [x] ~~depends on oxc-project/oxc#7031 disabled `nursery` in integration test \* the rules block overrides the rules from the other blocks, so this should be enabled in eslint ```json { "categories": { "correctness": "error", } "rules": { "no-invalid-regexp": "off" } } ```

I had intended to leave this in until we could rework some of the rule/plugin name resolution code, however this is causing issues with merging #6974. The mutability of `self` is difficult to resolve in that PR without more drastic changes. Since this isn't currently helping us out, I am simply removing the code for now until we can revisit this.

Boshen · 2024-11-13T05:40:35Z

Merge activity

Nov 13, 12:40 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Nov 13, 12:40 AM EST: A user added this pull request to the Graphite merge queue.
Nov 13, 12:45 AM EST: A user merged this pull request with the Graphite merge queue.

Part of #5653

I had intended to leave this in until we could rework some of the rule/plugin name resolution code, however this is causing issues with merging #6974. The mutability of `self` is difficult to resolve in that PR without more drastic changes. Since this isn't currently helping us out, I am simply removing the code for now until we can revisit this.

Part of #5653

I had intended to leave this in until we could rework some of the rule/plugin name resolution code, however this is causing issues with merging #6974. The mutability of `self` is difficult to resolve in that PR without more drastic changes. Since this isn't currently helping us out, I am simply removing the code for now until we can revisit this.

Part of #5653

I had intended to leave this in until we could rework some of the rule/plugin name resolution code, however this is causing issues with merging #6974. The mutability of `self` is difficult to resolve in that PR without more drastic changes. Since this isn't currently helping us out, I am simply removing the code for now until we can revisit this.

Part of #5653

## [0.12.0] - 2024-11-20 - 20d9080 linter: [**BREAKING**] Override plugins array when passed in config file (#7303) (camchenry) ### Features - 1d9f528 linter: Implement `unicorn/prefer-string-raw` lint rule (#7335) (Ryan Walker) - d445e0f linter: Implement `unicorn/consistent-existence-index-check` (#7262) (Ryan Walker) - 01ddf37 linter: Add `allowReject` option to `no-useless-promise-resolve-reject` (#7274) (no-yan) - 755a31b linter: Support bind function case for compatibility with `promise/no-return-wrap` (#7232) (no-yan) - 428770e linter: Add `import/no-namespace` rule (#7229) (Dmitry Zakharov) - 9c91151 linter: Implement typescript/no-empty-object-type (#6977) (Orenbek) - 2268a0e linter: Support `overrides` config field (#6974) (DonIsaac) - 3dcac1a linter: React/exhaustive-deps (#7151) (camc314) - d3a0119 oxlint: Add `cwd` property to `LintRunner` (#7352) (Alexander S.) ### Bug Fixes - ba0b2ff editor: Reload workspace configuration after change (#7302) (Alexander S.) - bc0e72c linter: Handle user variables correctly for import/no_commonjs (#7316) (Dmitry Zakharov) - bf839c1 linter: False positive in `jest/expect-expect` (#7341) (dalaoshu) - ff2a1d4 linter: Move `exhaustive-deps` to `react` (#7251) (camc314) - df5c535 linter: Revert unmatched rule error (#7257) (Cameron A McHenry) - c4ed230 linter: Fix false positive in eslint/no-cond-assign (#7241) (camc314) - ef847da linter: False positive in `jsx-a11y/iframe-has-title` (#7253) (dalaoshu) - 62b6327 linter: React/exhaustive-deps update span for unknown deps diagnostic (#7249) (camc314) ### Documentation - 4c124a8 editor/vscode: Update VS Code readme with installation instructions and available features (#7306) (Nicholas Rayburn) ### Refactor - c6a4868 linter: Temporarily remove unknown rules checking (#7260) (camchenry) ### Testing - 5190b7f editor: Add test setup (#7361) (Alexander S.) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>

DonIsaac mentioned this pull request Oct 28, 2024

refactor(linter): move LintPlugins from LintOptions to LintConfig #6932

Merged

DonIsaac requested review from Boshen and camchenry October 28, 2024 01:32

github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Oct 28, 2024

DonIsaac commented Oct 28, 2024

View reviewed changes

crates/oxc_linter/Cargo.toml Show resolved Hide resolved

DonIsaac force-pushed the don/10-27-feat_linter_support_overrides_config_field branch from 10fd2be to 3f72622 Compare October 28, 2024 01:48

DonIsaac commented Oct 28, 2024

View reviewed changes

crates/oxc_linter/src/config/flat.rs Show resolved Hide resolved

DonIsaac force-pushed the don/10-27-feat_linter_support_overrides_config_field branch from 3f72622 to aa1cfea Compare October 28, 2024 02:07

DonIsaac force-pushed the don/10-26-refactor_linter_move_lintplugins_from_lintoptions_to_lintconfig_ branch from 4c1f24b to f6a7fbb Compare October 28, 2024 03:30

DonIsaac force-pushed the don/10-27-feat_linter_support_overrides_config_field branch from aa1cfea to 75b2411 Compare October 28, 2024 03:31

DonIsaac marked this pull request as ready for review October 28, 2024 03:32

DonIsaac added this to the Oxlint Beta Milestone milestone Oct 28, 2024

Boshen reviewed Oct 28, 2024

View reviewed changes

DonIsaac force-pushed the don/10-26-refactor_linter_move_lintplugins_from_lintoptions_to_lintconfig_ branch from f6a7fbb to 0be2975 Compare October 28, 2024 17:41

DonIsaac force-pushed the don/10-27-feat_linter_support_overrides_config_field branch 3 times, most recently from 3018e86 to 37bb623 Compare October 28, 2024 17:49

Sysix mentioned this pull request Oct 28, 2024

feat: add buildFromOxlintConfigFile oxc-project/eslint-plugin-oxlint#197

Merged

18 tasks

DonIsaac requested a review from Boshen October 29, 2024 01:11

Boshen changed the base branch from don/10-26-refactor_linter_move_lintplugins_from_lintoptions_to_lintconfig_ to graphite-base/6974 October 29, 2024 01:28

Boshen force-pushed the graphite-base/6974 branch from 0be2975 to 8f1460e Compare October 29, 2024 01:32

Boshen force-pushed the don/10-27-feat_linter_support_overrides_config_field branch from 37bb623 to abc9ffd Compare October 29, 2024 01:32

Boshen changed the base branch from graphite-base/6974 to main October 29, 2024 01:33

Boshen reviewed Oct 31, 2024

View reviewed changes

pumano mentioned this pull request Nov 4, 2024

linter: add support "files" in config #7096

Closed

camchenry force-pushed the don/10-27-feat_linter_support_overrides_config_field branch 2 times, most recently from 555ca15 to b97ae7e Compare November 13, 2024 03:31

camchenry changed the base branch from main to 11-12-refactor_linter_temporarily_remove_unknown_rules_checking November 13, 2024 03:32

camchenry mentioned this pull request Nov 13, 2024

refactor(linter): temporarily remove unknown rules checking #7260

Merged

camchenry force-pushed the 11-12-refactor_linter_temporarily_remove_unknown_rules_checking branch from 9c18f1b to c6a4868 Compare November 13, 2024 03:41

Base automatically changed from 11-12-refactor_linter_temporarily_remove_unknown_rules_checking to main November 13, 2024 03:45

camchenry force-pushed the don/10-27-feat_linter_support_overrides_config_field branch from e84a98e to 21f5b71 Compare November 13, 2024 04:01

github-actions bot added the A-cli Area - CLI label Nov 13, 2024

camchenry requested a review from Boshen November 13, 2024 04:02

Boshen added the 0-merge Merge with Graphite Merge Queue label Nov 13, 2024

feat(linter): support overrides config field (#6974)

2268a0e

Part of #5653

Boshen force-pushed the don/10-27-feat_linter_support_overrides_config_field branch from 21f5b71 to 2268a0e Compare November 13, 2024 05:41

graphite-app bot merged commit 2268a0e into main Nov 13, 2024

graphite-app bot deleted the don/10-27-feat_linter_support_overrides_config_field branch November 13, 2024 05:45

Sysix mentioned this pull request Nov 13, 2024

add support for overrides in buildFromOxlint(Config) oxc-project/eslint-plugin-oxlint#247

Closed

Dunqing pushed a commit that referenced this pull request Nov 17, 2024

feat(linter): support overrides config field (#6974)

049d117

Part of #5653

Dunqing pushed a commit that referenced this pull request Nov 18, 2024

feat(linter): support overrides config field (#6974)

118b216

Part of #5653

Dunqing pushed a commit that referenced this pull request Nov 18, 2024

feat(linter): support overrides config field (#6974)

e15850f

Part of #5653

oxc-bot mentioned this pull request Nov 20, 2024

release(oxlint): v0.12.0 #7366

Merged

oxc-bot mentioned this pull request Nov 21, 2024

release(crates): v0.37.0 #7399

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

feat(linter): support `overrides` config field#6974

feat(linter): support `overrides` config field#6974
graphite-app[bot] merged 1 commit intomainfrom
don/10-27-feat_linter_support_overrides_config_field

DonIsaac commented Oct 28, 2024 •

edited

Loading

Uh oh!

graphite-app bot commented Oct 28, 2024

Uh oh!

DonIsaac commented Oct 28, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

DonIsaac commented Oct 28, 2024 •

edited

Loading

Uh oh!

DonIsaac commented Oct 28, 2024

Uh oh!

codspeed-hq bot commented Oct 28, 2024 •

edited

Loading

Uh oh!

Boshen left a comment

Uh oh!

camchenry commented Oct 28, 2024

Uh oh!

Boshen left a comment

Uh oh!

Boshen left a comment

Uh oh!

Boshen commented Nov 13, 2024 •

edited by graphite-app bot

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Comments

Conversation

DonIsaac commented Oct 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

graphite-app bot commented Oct 28, 2024

Your org has enabled the Graphite merge queue for merging into main

Uh oh!

DonIsaac commented Oct 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DonIsaac commented Oct 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DonIsaac commented Oct 28, 2024

Uh oh!

codspeed-hq bot commented Oct 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #6974 will not alter performance

Summary

Uh oh!

Boshen left a comment

Choose a reason for hiding this comment

Uh oh!

camchenry commented Oct 28, 2024

Uh oh!

Boshen left a comment

Choose a reason for hiding this comment

Uh oh!

Boshen left a comment

Choose a reason for hiding this comment

Uh oh!

Boshen commented Nov 13, 2024 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

DonIsaac commented Oct 28, 2024 •

edited

Loading

DonIsaac commented Oct 28, 2024 •

edited

Loading

DonIsaac commented Oct 28, 2024 •

edited

Loading

codspeed-hq bot commented Oct 28, 2024 •

edited

Loading

Boshen commented Nov 13, 2024 •

edited by graphite-app bot

Loading