Skip to content

Comments

refactor(linter): temporarily remove unknown rules checking#7260

Merged
graphite-app[bot] merged 1 commit intomainfrom
11-12-refactor_linter_temporarily_remove_unknown_rules_checking
Nov 13, 2024
Merged

refactor(linter): temporarily remove unknown rules checking#7260
graphite-app[bot] merged 1 commit intomainfrom
11-12-refactor_linter_temporarily_remove_unknown_rules_checking

Conversation

@camchenry
Copy link
Member

@camchenry camchenry commented Nov 13, 2024

I had intended to leave this in until we could rework some of the rule/plugin name resolution code, however this is causing issues with merging #6974. The mutability of self is difficult to resolve in that PR without more drastic changes. Since this isn't currently helping us out, I am simply removing the code for now until we can revisit this.

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 13, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Nov 13, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @camchenry and the rest of your teammates on Graphite Graphite

@camchenry camchenry requested a review from Boshen November 13, 2024 03:35
@camchenry camchenry marked this pull request as ready for review November 13, 2024 03:35
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 13, 2024

CodSpeed Performance Report

Merging #7260 will not alter performance

Comparing 11-12-refactor_linter_temporarily_remove_unknown_rules_checking (c6a4868) with main (df5c535)

Summary

✅ 30 untouched benchmarks

@camchenry camchenry added the 0-merge Merge with Graphite Merge Queue label Nov 13, 2024
Copy link
Member Author

camchenry commented Nov 13, 2024

Merge activity

  • Nov 12, 10:40 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 12, 10:40 PM EST: A user added this pull request to the Graphite merge queue.
  • Nov 12, 10:45 PM EST: A user merged this pull request with the Graphite merge queue.

I had intended to leave this in until we could rework some of the rule/plugin name resolution code, however this is causing issues with merging #6974. The mutability of `self` is difficult to resolve in that PR without more drastic changes. Since this isn't currently helping us out, I am simply removing the code for now until we can revisit this.
@camchenry camchenry force-pushed the 11-12-refactor_linter_temporarily_remove_unknown_rules_checking branch from 9c18f1b to c6a4868 Compare November 13, 2024 03:41
@graphite-app graphite-app bot merged commit c6a4868 into main Nov 13, 2024
@graphite-app graphite-app bot deleted the 11-12-refactor_linter_temporarily_remove_unknown_rules_checking branch November 13, 2024 03:45
Dunqing pushed a commit that referenced this pull request Nov 17, 2024
I had intended to leave this in until we could rework some of the rule/plugin name resolution code, however this is causing issues with merging #6974. The mutability of `self` is difficult to resolve in that PR without more drastic changes. Since this isn't currently helping us out, I am simply removing the code for now until we can revisit this.
Dunqing pushed a commit that referenced this pull request Nov 18, 2024
I had intended to leave this in until we could rework some of the rule/plugin name resolution code, however this is causing issues with merging #6974. The mutability of `self` is difficult to resolve in that PR without more drastic changes. Since this isn't currently helping us out, I am simply removing the code for now until we can revisit this.
Dunqing pushed a commit that referenced this pull request Nov 18, 2024
I had intended to leave this in until we could rework some of the rule/plugin name resolution code, however this is causing issues with merging #6974. The mutability of `self` is difficult to resolve in that PR without more drastic changes. Since this isn't currently helping us out, I am simply removing the code for now until we can revisit this.
Boshen added a commit that referenced this pull request Nov 20, 2024
## [0.12.0] - 2024-11-20

- 20d9080 linter: [**BREAKING**] Override plugins array when passed in
config file (#7303) (camchenry)

### Features

- 1d9f528 linter: Implement `unicorn/prefer-string-raw` lint rule
(#7335) (Ryan Walker)
- d445e0f linter: Implement `unicorn/consistent-existence-index-check`
(#7262) (Ryan Walker)
- 01ddf37 linter: Add `allowReject` option to
`no-useless-promise-resolve-reject` (#7274) (no-yan)
- 755a31b linter: Support bind function case for compatibility with
`promise/no-return-wrap` (#7232) (no-yan)
- 428770e linter: Add `import/no-namespace` rule (#7229) (Dmitry
Zakharov)
- 9c91151 linter: Implement typescript/no-empty-object-type (#6977)
(Orenbek)
- 2268a0e linter: Support `overrides` config field (#6974) (DonIsaac)
- 3dcac1a linter: React/exhaustive-deps (#7151) (camc314)
- d3a0119 oxlint: Add `cwd` property to `LintRunner` (#7352) (Alexander
S.)

### Bug Fixes

- ba0b2ff editor: Reload workspace configuration after change (#7302)
(Alexander S.)
- bc0e72c linter: Handle user variables correctly for import/no_commonjs
(#7316) (Dmitry Zakharov)
- bf839c1 linter: False positive in `jest/expect-expect` (#7341)
(dalaoshu)
- ff2a1d4 linter: Move `exhaustive-deps` to `react` (#7251) (camc314)
- df5c535 linter: Revert unmatched rule error (#7257) (Cameron A
McHenry)
- c4ed230 linter: Fix false positive in eslint/no-cond-assign (#7241)
(camc314)
- ef847da linter: False positive in `jsx-a11y/iframe-has-title` (#7253)
(dalaoshu)
- 62b6327 linter: React/exhaustive-deps update span for unknown deps
diagnostic (#7249) (camc314)

### Documentation

- 4c124a8 editor/vscode: Update VS Code readme with installation
instructions and available features (#7306) (Nicholas Rayburn)

### Refactor

- c6a4868 linter: Temporarily remove unknown rules checking (#7260)
(camchenry)

### Testing

- 5190b7f editor: Add test setup (#7361) (Alexander S.)

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant