feat(linter): implement typescript/no-empty-object-type by Orenbek · Pull Request #6977 · oxc-project/oxc

Orenbek · 2024-10-28T09:25:49Z

typescript/no-empty-object-type

…mpty_object_type

graphite-app · 2024-10-28T09:25:53Z

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

codspeed-hq · 2024-10-28T09:43:21Z

CodSpeed Performance Report

Merging #6977 will not alter performance

_{Comparing Orenbek:oxlint-ts_rules (422a037) with main (2268a0e)}

Summary

✅ 30 untouched benchmarks

crates/oxc_linter/src/rules/typescript/no_empty_object_type.rs

crates/oxc_linter/src/rules/typescript/no_unsafe_function_type.rs

pumano · 2024-11-07T15:57:27Z

@camchenry Could you check it too please? Useful rule

crates/oxc_linter/src/rules/typescript/no_empty_object_type.rs

crates/oxc_linter/src/snapshots/no_empty_object_type.snap

…-ts_rules

camc314

looks good to me, thanks!

camchenry

Thanks for all of your work on this. I think this looks good, I think the last thing we should do is add a separate diagnostic for empty interfaces. Then this looks like it should be ready.

crates/oxc_linter/src/snapshots/no_empty_object_type.snap

crates/oxc_linter/src/rules/typescript/no_empty_object_type.rs

camc314

@Orenbek thank you !

graphite-app · 2024-11-13T09:30:37Z

Merge activity

Nov 13, 4:30 AM EST: A user added this pull request to the Graphite merge queue.
Nov 13, 4:30 AM EST: The Graphite merge queue couldn't merge this PR because it failed for an unknown reason (Stack merges are not currently supported for forked repositories. Please create a branch in the target repository in order to merge).

## [0.12.0] - 2024-11-20 - 20d9080 linter: [**BREAKING**] Override plugins array when passed in config file (#7303) (camchenry) ### Features - 1d9f528 linter: Implement `unicorn/prefer-string-raw` lint rule (#7335) (Ryan Walker) - d445e0f linter: Implement `unicorn/consistent-existence-index-check` (#7262) (Ryan Walker) - 01ddf37 linter: Add `allowReject` option to `no-useless-promise-resolve-reject` (#7274) (no-yan) - 755a31b linter: Support bind function case for compatibility with `promise/no-return-wrap` (#7232) (no-yan) - 428770e linter: Add `import/no-namespace` rule (#7229) (Dmitry Zakharov) - 9c91151 linter: Implement typescript/no-empty-object-type (#6977) (Orenbek) - 2268a0e linter: Support `overrides` config field (#6974) (DonIsaac) - 3dcac1a linter: React/exhaustive-deps (#7151) (camc314) - d3a0119 oxlint: Add `cwd` property to `LintRunner` (#7352) (Alexander S.) ### Bug Fixes - ba0b2ff editor: Reload workspace configuration after change (#7302) (Alexander S.) - bc0e72c linter: Handle user variables correctly for import/no_commonjs (#7316) (Dmitry Zakharov) - bf839c1 linter: False positive in `jest/expect-expect` (#7341) (dalaoshu) - ff2a1d4 linter: Move `exhaustive-deps` to `react` (#7251) (camc314) - df5c535 linter: Revert unmatched rule error (#7257) (Cameron A McHenry) - c4ed230 linter: Fix false positive in eslint/no-cond-assign (#7241) (camc314) - ef847da linter: False positive in `jsx-a11y/iframe-has-title` (#7253) (dalaoshu) - 62b6327 linter: React/exhaustive-deps update span for unknown deps diagnostic (#7249) (camc314) ### Documentation - 4c124a8 editor/vscode: Update VS Code readme with installation instructions and available features (#7306) (Nicholas Rayburn) ### Refactor - c6a4868 linter: Temporarily remove unknown rules checking (#7260) (camchenry) ### Testing - 5190b7f editor: Add test setup (#7361) (Alexander S.) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>

feat(oxlint): add typescript lint rule no_unsafe_function_type & no_e…

4786321

…mpty_object_type

github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Oct 28, 2024

DonIsaac reviewed Oct 28, 2024

View reviewed changes

Orenbek added 3 commits October 29, 2024 09:51

fix(oxlint): lint message fixed

810a943

fix(oxlint): regenerate snapshot; impl From trait

e5c2d9a

fix(lint): one rule per PR

05e81e8

Orenbek changed the title ~~feat(oxlint): add typescript lint rule no_unsafe_function_type, no_empty_object_type~~ feat(oxlint): add typescript lint rule no_empty_object_type Oct 29, 2024

camc314 requested a review from DonIsaac November 7, 2024 17:02

camchenry reviewed Nov 8, 2024

View reviewed changes

crates/oxc_linter/src/rules/typescript/no_empty_object_type.rs Show resolved Hide resolved

camchenry reviewed Nov 8, 2024

View reviewed changes

Orenbek added 2 commits November 11, 2024 15:23

Merge branch 'main' of https://github.com/oxc-project/oxc into oxlint…

2d1da4d

…-ts_rules

fix(oxlint): optimize code; update snapshot file

6d01ed2

camc314 requested a review from camchenry November 12, 2024 10:07

camc314 approved these changes Nov 12, 2024

View reviewed changes

camchenry approved these changes Nov 12, 2024

View reviewed changes

crates/oxc_linter/src/snapshots/no_empty_object_type.snap Outdated Show resolved Hide resolved

crates/oxc_linter/src/rules/typescript/no_empty_object_type.rs Outdated Show resolved Hide resolved

chore(oxlint): optimize error message

422a037

camc314 approved these changes Nov 13, 2024

View reviewed changes

camc314 changed the title ~~feat(oxlint): add typescript lint rule no_empty_object_type~~ feat(linter): implement typescript/no-empty-object-type Nov 13, 2024

camc314 added the 0-merge Merge with Graphite Merge Queue label Nov 13, 2024

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 13, 2024

camc314 merged commit 9c91151 into oxc-project:main Nov 13, 2024

Dunqing pushed a commit that referenced this pull request Nov 17, 2024

feat(linter): implement typescript/no-empty-object-type (#6977)

4d9a52e

Dunqing pushed a commit that referenced this pull request Nov 18, 2024

feat(linter): implement typescript/no-empty-object-type (#6977)

9b0fdb3

Dunqing pushed a commit that referenced this pull request Nov 18, 2024

feat(linter): implement typescript/no-empty-object-type (#6977)

7a1e0f9

oxc-bot mentioned this pull request Nov 20, 2024

release(oxlint): v0.12.0 #7366

Merged

Uh oh!

Comments

Conversation

Orenbek commented Oct 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

graphite-app bot commented Oct 28, 2024

Your org has enabled the Graphite merge queue for merging into main

Uh oh!

codspeed-hq bot commented Oct 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #6977 will not alter performance

Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pumano commented Nov 7, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

camc314 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

camchenry left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

camc314 left a comment

Choose a reason for hiding this comment

Uh oh!

graphite-app bot commented Nov 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Orenbek commented Oct 28, 2024 •

edited

Loading

codspeed-hq bot commented Oct 28, 2024 •

edited

Loading

camc314 left a comment •

edited

Loading

graphite-app bot commented Nov 13, 2024 •

edited

Loading